Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tagging support through StorageClass.parameters #1199

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Adding tagging support through StorageClass.parameters #1199

merged 1 commit into from
Apr 5, 2022

Conversation

rdpsin
Copy link
Contributor

@rdpsin rdpsin commented Apr 5, 2022

Is this a bug fix or adding new feature?
/kind feature

What is this PR about? / Why do we need it?
This commit adds tagging support (w/ string interpolation) through StorageClass.parameters.

For more information about the design, refer to #1190 and the markdown file in docs/.

Also, see #180.

What testing is done?
Unit tests
e2e test
Manual testing by creating volumes specified with tags through StorageClass.parameters.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @rdpsin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 5, 2022
@rdpsin rdpsin mentioned this pull request Apr 5, 2022
Closed
@gtxu
Copy link
Contributor

gtxu commented Apr 5, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2022
@rdpsin
Adding tagging support through StorageClass.parameters
e4da85a 
This commit adds tagging support through StorageClass.parameters.

For more information about the design, refer to kubernetes-sigs#1190

Signed-off-by: Rishabh Singhvi <rdpsin@amazon.com>
@rdpsin
Copy link
Contributor Author

rdpsin commented Apr 5, 2022

/retest

@gtxu
Copy link
Contributor

gtxu commented Apr 5, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtxu, rdpsin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit da9873c into kubernetes-sigs:master Apr 5, 2022
@rdpsin rdpsin mentioned this pull request Apr 12, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayberk ayberk Awaiting requested review from ayberk

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@gtxu gtxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rdpsin @k8s-ci-robot @gtxu