Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image tags in ecr-public kustomization #1305

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

torredil
Copy link
Member

Signed-off-by: Eddie Torres torredil@amazon.com

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?

kubectl apply -k "github.com/kubernetes-sigs/aws-ebs-csi-driver/deploy/kubernetes/overlays/stable/?ref=master"

error: accumulating resources: accumulation err='accumulating resources from 
'./ecr-public': '/tmp/kustomize-014789932/deploy/kubernetes/overlays/stable/ecr-public' must resolve to a file': 
couldn't make target for path '/tmp/kustomize-014789932/deploy/kubernetes/overlays/stable/ecr-public': json: unknown field "tagSuffix"

What testing is done?

kubectl apply -k "github.com/torredil/aws-ebs-csi-driver/deploy/kubernetes/overlays/stable/?ref=master"

serviceaccount/ebs-csi-controller-sa unchanged
serviceaccount/ebs-csi-node-sa unchanged
clusterrole.rbac.authorization.k8s.io/ebs-csi-node-role unchanged
clusterrole.rbac.authorization.k8s.io/ebs-external-attacher-role unchanged
clusterrole.rbac.authorization.k8s.io/ebs-external-provisioner-role unchanged
clusterrole.rbac.authorization.k8s.io/ebs-external-resizer-role unchanged
clusterrole.rbac.authorization.k8s.io/ebs-external-snapshotter-role unchanged
clusterrolebinding.rbac.authorization.k8s.io/ebs-csi-attacher-binding unchanged
clusterrolebinding.rbac.authorization.k8s.io/ebs-csi-node-getter-binding unchanged
clusterrolebinding.rbac.authorization.k8s.io/ebs-csi-provisioner-binding unchanged
clusterrolebinding.rbac.authorization.k8s.io/ebs-csi-resizer-binding unchanged
clusterrolebinding.rbac.authorization.k8s.io/ebs-csi-snapshotter-binding unchanged

Signed-off-by: Eddie Torres <torredil@amazon.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2022
@torredil
Copy link
Member Author

/retest

@torredil
Copy link
Member Author

/retest

@torredil torredil requested review from gtxu and rdpsin July 11, 2022 19:29
@rdpsin
Copy link
Contributor

rdpsin commented Jul 11, 2022

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2022
@gtxu
Copy link
Contributor

gtxu commented Jul 11, 2022

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4ac688f into kubernetes-sigs:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
4 participants