Change fsGroupPolicy to File

[ConnorJC3]

See #1365 (comment)

This might need to be revisited in the future with multi-attach volumes, but for now is 100% safe.

[k8s-ci-robot]

Hi @ConnorJC3. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gnufied]

/ok-to-test

[gnufied]

This might need to be revisited in the future with multi-attach volumes, but for now is 100% safe.

Is the driver going to support read-write-many multi-attach volumes? It seems like standard filesystems like ext4, XFS does not have necessary fencing to multi-attach same volume in write mode.

If multi-attach will only support read-only, we should still be fine with file as fsGroupPolicy.

[ConnorJC3]

EBS has multiple writer support for multi-attach volumes, but I've heard it's very wonky and has several limitations. I haven't tested but I assume they at least partially deal with the filesystem issue on their end?

There's a long-open PR for multi-atrach support that would allow multiple writers (#1178), but it needs serious reworking and probably won't be merged anytime soon.

[torredil]

/lgtm

[gtxu]

/lgtm

[gnufied]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[z0rc]

This changes immutable field in CSIDriver resource on existing deployments. It was undefined previously and therefore kubernetes sets it to ReadWriteOnceWithFSType by default.

How this change is expected to be applied by end user?

[gnufied]

Hmm. not a helm person, but is there a way it could delete and recreate the resource for immutable fields? We do that in our operators when something immutable has to be changed inside an object. :(

[ConnorJC3]

@gnufied unfortunately, as far as I can tell, no. You might be able to get that behavior with helm install --replace, but the docs explicitly call that option out as "not production ready" (and there is no --replace argument to helm upgrade, which makes it even more jank).