Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all taint for toleration csi-node by default #1381

Merged
merged 1 commit into from Sep 15, 2022
Merged

Allow all taint for toleration csi-node by default #1381

merged 1 commit into from Sep 15, 2022

Conversation

gtxu
Copy link
Contributor

@gtxu gtxu commented Sep 12, 2022

Signed-off-by: Gengtao Xu gengtaox@amazon.com

What is this PR about? / Why do we need it?
This PR removed the previous policy of csi-node taint toleration and make allowing all taint by default. For csi-node, unless customized configuration, we should allow all nodes taint for PV availability.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 12, 2022
torredil
torredil reviewed Sep 12, 2022
View reviewed changes
Copy link
Member

@torredil torredil left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a breaking change. Let's just set tolerateAllTaints: true in values.yaml instead and update the docs.

@gtxu
Copy link
Contributor Author

gtxu commented Sep 12, 2022

This would be a breaking change. Let's just set tolerateAllTaints: true in values.yaml instead and update the docs.

Will update the doc. I believe the current toleration is from this issue. And it should only work for the csi-controller. So it would be better to remove the existing policy.

@gtxu gtxu changed the title Allow all taint for csi-node by default Allow all taint for toleration csi-node by default Sep 12, 2022
@gtxu gtxu marked this pull request as draft September 12, 2022 17:08
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2022
@ConnorJC3
Copy link
Contributor

Agree with @torredil : just changing the default is better here. This change prevents helm users from customizing the tolerations when they don't want to tolerate all taints.

@ghost
Copy link

ghost commented Sep 12, 2022

Please DO NOT merge this as is, as mentioned here we rely on the ability to customize the tolerations (we have a multi-cloud cluster and use taints to specify which cloud certain components such as the CSI driver run on).

@gtxu
Copy link
Contributor Author

gtxu commented Sep 12, 2022 •
edited

Please DO NOT merge this as is, as mentioned here we rely on the ability to customize the tolerations (we have a multi-cloud cluster and use taints to specify which cloud certain components such as the CSI driver run on).

Sure, with the awareness that it will break current workflow. I am going to keep the all taint configurable in values. The action to remove the CriticalAddonsOnly and effect: NoExecute is because they are csi-controller desired toleration instead of csi-node. For csi-node we would like it to deployed to all nodes unless there are customized configurations.

Please let me know if you have any further concerns.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2022
@gtxu gtxu closed this Sep 15, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 15, 2022
@gtxu gtxu reopened this Sep 15, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2022
@gtxu gtxu marked this pull request as ready for review September 15, 2022 19:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2022
ConnorJC3
ConnorJC3 reviewed Sep 15, 2022
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code changes lgtm, spotted a few spots the docs grammar could be improved

docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
@gtxu
Allow all taint for csi-node by default
8ec4ead 
Signed-off-by: Gengtao Xu <gengtaox@amazon.com>
@gtxu
Copy link
Contributor Author

gtxu commented Sep 15, 2022

@ConnorJC3 Thanks for the suggestions, just fixed it.

ConnorJC3
ConnorJC3 approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

torredil
torredil approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, gtxu, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 87d62c0 into kubernetes-sigs:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 ConnorJC3 approved these changes

@torredil torredil torredil approved these changes

@rdpsin rdpsin Awaiting requested review from rdpsin

@wongma7 wongma7 Awaiting requested review from wongma7

@bertinatto bertinatto Awaiting requested review from bertinatto

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gtxu @ConnorJC3 @k8s-ci-robot @torredil