Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1465

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Update README.md #1465

merged 1 commit into from
Dec 29, 2022

Conversation

torredil
Copy link
Member

What is this PR about? / Why do we need it?

  • Update compatibility information.

Signed-off-by: Eddie Torres torredil@amazon.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2022
@rdpsin
Copy link
Contributor

rdpsin commented Dec 27, 2022

Can you update the commit description and message to more accurately reflect what's going on in the PR? (Update README.md seems very vague).

@rdpsin
Copy link
Contributor

rdpsin commented Dec 27, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2022
@torredil
Update compatibility info in README
86dd69c 
Consolidate compatibility information and clarify release cadence

Signed-off-by: Eddie Torres <torredil@amazon.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2022
@rdpsin
Copy link
Contributor

rdpsin commented Dec 27, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2022
@ConnorJC3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit aba27bb into kubernetes-sigs:master Dec 29, 2022
@rob-howie-depop
Copy link

You missed a reference to the "compatibility matrix" here:
https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/docs/install.md#deploy-driver

I just spent an hour reading through AWS pages and this repo, before realising that someone might have deleted it!

@torredil torredil mentioned this pull request Jan 17, 2023
Merged
@torredil
Copy link
Member Author

@rob-howie-depop Thanks for catching that! #1484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 Awaiting requested review from ConnorJC3

@rdpsin rdpsin Awaiting requested review from rdpsin

Assignees

@ConnorJC3 ConnorJC3

@rdpsin rdpsin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@torredil @rdpsin @ConnorJC3 @k8s-ci-robot @rob-howie-depop