Move test integration #153

kschumy · 2018-12-20T01:33:46Z

Is this a bug fix or adding new feature?
Feature

What is this PR about? / Why do we need it?
make test-integration uses aws-k8s-tester

What testing is done?
Ran locally

k8s-ci-robot · 2018-12-20T01:33:59Z

Hi @kschumy. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gyuho · 2018-12-20T01:37:10Z

/hold

@leakingtapan

As we discussed, we are introducing EC2 based integration tests.

We will test this PR locally.

coveralls · 2018-12-20T01:38:59Z

Pull Request Test Coverage Report for Build 281

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.352%

Totals
Change from base Build 272:	0.0%
Covered Lines:	572
Relevant Lines:	1136

💛 - Coveralls

coveralls · 2018-12-20T01:38:59Z

Pull Request Test Coverage Report for Build 247

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.352%

Totals
Change from base Build 241:	0.0%
Covered Lines:	572
Relevant Lines:	1136

💛 - Coveralls

k8s-ci-robot · 2018-12-20T01:45:33Z

@kschumy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leakingtapan · 2018-12-20T17:59:44Z

/ok-to-test

leakingtapan

Could you add some README (maybe under tests/integration) about how to run the integration test locally and what are required for integration test to run, etc?

And lets squash the commit once all the changes are done

leakingtapan · 2018-12-20T18:08:56Z

hack/test-integration.sh

+
+if ! [[ "$0" =~ hack/test-integration.sh ]]; then
+  echo "must be run from repository root"
+  exit 255


Why do we use 255 as exit code? Here is the list of special meaning of exit code: http://tldp.org/LDP/abs/html/exitcodes.html Maybe we can use 1 as general error

Yeah let's use exit 127 for illegal command, instead.

/cc @kschumy

k8s-ci-robot · 2018-12-20T22:56:16Z

@gyuho: GitHub didn't allow me to request PR reviews from the following users: kschumy.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Yeah let's use exit 127 for illegal command, instead.

/cc @kschumy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hack/test-integration.sh

gyuho · 2018-12-21T00:02:01Z

hack/test-integration.sh

+fi
+
+go test -c ./tests/integration/... -o bin/integration.test && \
+  sudo -E bin/integration.test -ginkgo.v


Ok let's instead do:

sudo -E bin/integration.test -test.v -ginkgo.v

kschumy

@leakingtapan was this what you wanted?

036cffe

leakingtapan · 2018-12-21T06:10:27Z

@leakingtapan was this what you wanted?
036cffe

Looks like a good start

kschumy · 2018-12-22T02:07:40Z

tests/integration/README.md

+#### Using `aws-ebs-csi-driver`
+
+```bash
+cd ${GOPATH}/src/github.com/aws/aws-k8s-tester


Since make test-integration now runs aws-k8s-tester automatically, I changed this to being about running aws-k8s-tester independently

tests/integration/README.md

leakingtapan · 2018-12-22T05:09:32Z

tests/integration/README.md

@@ -0,0 +1,33 @@
+## Running Integration Tests with `aws-k8s-tester`
+
+[`aws-k8s-tester`](https://github.com/aws/aws-k8s-tester) is an e2e test deployment interface for testing K8s clusters on AWS and is used in conjunction with `aws-ebs-csi-driver` for csi integration tests.


Remove this line

tests/integration/README.md

leakingtapan · 2018-12-22T05:16:10Z

Add some comments on the README for integ test. Could you squash all the changes into one commit after all the change?

Makefile

gyuho · 2018-12-24T22:09:47Z

/lgtm

Defer to @leakingtapan.

In the meantime, @kschumy will be adding a Prow job in upstream test-infra.

Thanks!

hack: create test-integration.sh Makefile: use aws-k8s-tester with test-integration tests/integration: create README

gyuho · 2018-12-24T23:01:04Z

/lgtm

thanks for picking up the latest!

leakingtapan · 2018-12-24T23:48:00Z

/lgtm
/approve

k8s-ci-robot · 2018-12-24T23:48:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kschumy, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [leakingtapan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gyuho · 2018-12-24T23:52:02Z

/hold cancel

@kschumy will look into ways to automate release version fetch, in the following PR.

Thanks!

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2018

k8s-ci-robot requested review from jsafrane and leakingtapan December 20, 2018 01:33

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 20, 2018

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 20, 2018

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2018

kschumy force-pushed the move-test-integration branch from e5c4aaa to dd7d262 Compare December 20, 2018 01:43

kschumy force-pushed the move-test-integration branch 2 times, most recently from edfca00 to 23db543 Compare December 20, 2018 03:28

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 20, 2018

leakingtapan reviewed Dec 20, 2018

View reviewed changes

gyuho reviewed Dec 20, 2018

View reviewed changes

hack/test-integration.sh Show resolved Hide resolved

gyuho reviewed Dec 21, 2018

View reviewed changes

kschumy force-pushed the move-test-integration branch 2 times, most recently from 871122f to 036cffe Compare December 21, 2018 05:31

kschumy commented Dec 21, 2018

View reviewed changes

leakingtapan mentioned this pull request Dec 21, 2018

Fix integration Test #156

Merged

kschumy force-pushed the move-test-integration branch 3 times, most recently from feb3211 to dc0140c Compare December 22, 2018 02:04

kschumy commented Dec 22, 2018

View reviewed changes

leakingtapan reviewed Dec 22, 2018

View reviewed changes

leakingtapan mentioned this pull request Dec 22, 2018

Basic testing infra with Prow #36

Closed

5 tasks

gyuho reviewed Dec 24, 2018

View reviewed changes

Makefile Outdated Show resolved Hide resolved

kschumy force-pushed the move-test-integration branch 2 times, most recently from 261aed7 to 9957ffd Compare December 24, 2018 22:07

k8s-ci-robot assigned gyuho Dec 24, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2018

use aws-k8s-tester for test-integration

ccaa7a0

hack: create test-integration.sh Makefile: use aws-k8s-tester with test-integration tests/integration: create README

kschumy force-pushed the move-test-integration branch from 9957ffd to ccaa7a0 Compare December 24, 2018 23:00

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2018

k8s-ci-robot assigned leakingtapan Dec 24, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2018

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 24, 2018

k8s-ci-robot merged commit e25854c into kubernetes-sigs:master Dec 24, 2018

kschumy deleted the move-test-integration branch December 26, 2018 22:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move test integration #153

Move test integration #153

kschumy commented Dec 20, 2018

k8s-ci-robot commented Dec 20, 2018

gyuho commented Dec 20, 2018

coveralls commented Dec 20, 2018 •

edited

coveralls commented Dec 20, 2018

k8s-ci-robot commented Dec 20, 2018

leakingtapan commented Dec 20, 2018

leakingtapan left a comment •

edited

leakingtapan Dec 20, 2018

gyuho Dec 20, 2018

k8s-ci-robot commented Dec 20, 2018

gyuho Dec 21, 2018

kschumy left a comment •

edited

leakingtapan commented Dec 21, 2018 •

edited

kschumy Dec 22, 2018

leakingtapan Dec 22, 2018

kschumy Dec 24, 2018

leakingtapan commented Dec 22, 2018

gyuho commented Dec 24, 2018

gyuho commented Dec 24, 2018

leakingtapan commented Dec 24, 2018

k8s-ci-robot commented Dec 24, 2018

gyuho commented Dec 24, 2018

		@@ -0,0 +1,33 @@
		## Running Integration Tests with `aws-k8s-tester`

		[`aws-k8s-tester`](https://github.com/aws/aws-k8s-tester) is an e2e test deployment interface for testing K8s clusters on AWS and is used in conjunction with `aws-ebs-csi-driver` for csi integration tests.

Move test integration #153

Move test integration #153

Conversation

kschumy commented Dec 20, 2018

k8s-ci-robot commented Dec 20, 2018

gyuho commented Dec 20, 2018

coveralls commented Dec 20, 2018 • edited

Pull Request Test Coverage Report for Build 281

💛 - Coveralls

coveralls commented Dec 20, 2018

Pull Request Test Coverage Report for Build 247

💛 - Coveralls

k8s-ci-robot commented Dec 20, 2018

leakingtapan commented Dec 20, 2018

leakingtapan left a comment • edited

Choose a reason for hiding this comment

leakingtapan Dec 20, 2018

Choose a reason for hiding this comment

gyuho Dec 20, 2018

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 20, 2018

gyuho Dec 21, 2018

Choose a reason for hiding this comment

kschumy left a comment • edited

Choose a reason for hiding this comment

leakingtapan commented Dec 21, 2018 • edited

kschumy Dec 22, 2018

Choose a reason for hiding this comment

leakingtapan Dec 22, 2018

Choose a reason for hiding this comment

kschumy Dec 24, 2018

Choose a reason for hiding this comment

leakingtapan commented Dec 22, 2018

gyuho commented Dec 24, 2018

gyuho commented Dec 24, 2018

leakingtapan commented Dec 24, 2018

k8s-ci-robot commented Dec 24, 2018

gyuho commented Dec 24, 2018

coveralls commented Dec 20, 2018 •

edited

leakingtapan left a comment •

edited

kschumy left a comment •

edited

leakingtapan commented Dec 21, 2018 •

edited