Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce scope of testing for test-helm-chart #1533

Merged
merged 1 commit into from Mar 20, 2023

Conversation

torredil
Copy link
Member

@torredil torredil commented Mar 14, 2023

What is this PR about? / Why do we need it?

  • Currently, we run the entire External.Storage e2e suite when testing Helm chart changes / upgrades -- overkill. This PR significantly reduces the number of tests we run to a select few that still cover all the functionality:

    • Kubernetes e2e suite: [It] External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)] volumes should store data
    • Kubernetes e2e suite: [It] External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (delayed binding)] topology should provision a volume and schedule a pod with AllowedTopologies
    • Kubernetes e2e suite: [It] External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand Verify if offline PVC expansion works
    • Kubernetes e2e suite: [It] External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand should resize volume when PVC is edited while pod is using it
    • Kubernetes e2e suite: [It] External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)] volumeIO should write files of various sizes, verify size, validate content [Slow]
    • Kubernetes e2e suite: [It] External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic Snapshot (delete policy)] snapshottable[Feature:VolumeSnapshotDataSource] volume snapshot controller should check snapshot fields, check restore correctly works after modifying source data, check deletion (persistent)
  • Only run snapshot tests if CRDs detected.

  • closes Helm test times out post install #1522

What testing is done?

// volumesnapshots.snapshot.storage.k8s.io CRD not installed.
I0313 23:28:16.880359    1970 ginkgo.go:111] Running ginkgo test as /workspace/_rundir/e2e-kubernetes/ginkgo [--nodes=25 /workspace/_rundir/e2e-kubernetes/e2e.test -- --kubeconfig=/root/.kube/config --kubectl-path=/workspace/_rundir/e2e-kubernetes/kubectl --ginkgo.skip=\[Disruptive\]|\[Serial\] --ginkgo.focus=\bebs.csi.aws.com\b.+(validate content|resize volume|offline PVC|AllowedTopologies|store data) --report-dir=/workspace/_artifacts --ginkgo.timeout=24h --ginkgo.flake-attempts=1 -storage.testdriver=/etc/config/manifests.yaml]

Ran 11 of 7332 Specs in 177.293 seconds
SUCCESS! -- 11 Passed | 0 Failed | 0 Pending | 7321 Skipped

// volumesnapshots.snapshot.storage.k8s.io CRD installed.
I0313 23:34:27.447735    1952 ginkgo.go:111] Running ginkgo test as /workspace/_rundir/e2e-kubernetes/ginkgo [--nodes=25 /workspace/_rundir/e2e-kubernetes/e2e.test -- --kubeconfig=/root/.kube/config --kubectl-path=/workspace/_rundir/e2e-kubernetes/kubectl --ginkgo.skip=\[Disruptive\]|\[Serial\] --ginkgo.focus=\bebs.csi.aws.com\b.+(validate content|resize volume|offline PVC|AllowedTopologies|store data|snapshot fields) --report-dir=/workspace/_artifacts --ginkgo.timeout=24h --ginkgo.flake-attempts=1 -storage.testdriver=/etc/config/manifests.yaml]

Ran 17 of 7332 Specs in 268.808 seconds
SUCCESS! -- 17 Passed | 0 Failed | 0 Pending | 7315 Skipped

Only run snapshot tests if CRDs detected

Signed-off-by: Eddie Torres <torredil@amazon.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2023
@ConnorJC3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@gtxu
Copy link
Contributor

gtxu commented Mar 15, 2023

/lgtm

@torredil
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hanyuel, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6a09c59 into kubernetes-sigs:master Mar 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm test times out post install
5 participants