Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure lievness probe check for node-driver-registrar #1570

Merged
merged 1 commit into from
Apr 17, 2023
Merged

configure lievness probe check for node-driver-registrar #1570

merged 1 commit into from
Apr 17, 2023

Conversation

gtxu
Copy link
Contributor

@gtxu gtxu commented Apr 13, 2023 •
edited

Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
Adding configure map for liveness-probe check in node-driver-registrar
What testing is done?
Block the CSI socket /csi/csi.sock access, after csi-node pod start up, node-driver-registrar reports log as following:

I0413 21:54:55.333415       1 main.go:167] Version: v2.7.0
I0413 21:54:55.333449       1 main.go:168] Running node-driver-registrar in mode=registration
I0413 21:54:55.333810       1 main.go:192] Attempting to open a gRPC connection with: "/csi/csi"
W0413 21:55:05.334651       1 connection.go:173] Still connecting to unix:///csi/csi.sock
W0413 21:55:15.334376       1 connection.go:173] Still connecting to unix:///csi/csi.sock
W0413 21:55:25.333936       1 connection.go:173] Still connecting to unix:///csi/csi.sock
W0413 21:55:35.334818       1 connection.go:173] Still connecting to unix:///csi/csi.sock

After 30s initial delay, csi-node pod get restarted as node failed to register:

NAME                                  READY   STATUS    RESTARTS      AGE
ebs-csi-controller-7b4cd58f49-2rl5h   5/5     Running   0             67m
ebs-csi-controller-7b4cd58f49-679fg   5/5     Running   0             67m
ebs-csi-node-5zsdw                    3/3     Running   2 (44s ago)   2m25s
ebs-csi-node-bjpr2                    3/3     Running   2 (42s ago)   2m23s
ebs-csi-node-ppq9v                    3/3     Running   2 (27s ago)   2m28s
ebs-csi-node-q5ht5                    3/3     Running   2 (26s ago)   2m26s

Without liveness probe configured, csi-node pod running without further action.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 13, 2023
@gtxu
Copy link
Contributor Author

gtxu commented Apr 13, 2023

/test pull-aws-ebs-csi-driver-test-helm-chart

@gtxu gtxu force-pushed the add-liveness-probe-sidecar branch from edaa30c to 9daf96d Compare April 13, 2023 22:02
@gtxu gtxu marked this pull request as ready for review April 13, 2023 22:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2023
@gtxu
Copy link
Contributor Author

gtxu commented Apr 14, 2023

/retest

3 similar comments
@ConnorJC3
Copy link
Contributor

/retest

@ConnorJC3
Copy link
Contributor

/retest

@ConnorJC3
Copy link
Contributor

/retest

@gtxu gtxu force-pushed the add-liveness-probe-sidecar branch from 9daf96d to 5a59297 Compare April 14, 2023 20:59
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 14, 2023
@ConnorJC3
Copy link
Contributor

/retest

@ConnorJC3
Copy link
Contributor

/retest
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ConnorJC3
Copy link
Contributor

/retest

2 similar comments
@ConnorJC3
Copy link
Contributor

/retest

@ConnorJC3
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit cfe3673 into kubernetes-sigs:master Apr 17, 2023
4 checks passed
@gtxu gtxu deleted the add-liveness-probe-sidecar branch April 20, 2023 20:58
@torredil torredil mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@ConnorJC3 ConnorJC3 Awaiting requested review from ConnorJC3

@rdpsin rdpsin Awaiting requested review from rdpsin

Assignees

@ConnorJC3 ConnorJC3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gtxu @k8s-ci-robot @ConnorJC3 @torredil