remove condition on iopspergb key being mandatory for io1 volumes

[surian]

Condition on iopsPerGB key being mandatory for io1 volumes introduced by #767 is irrelevant and should be removed as it's possible to create a io1 volume by specifying the desired number of iops.

$ aws ec2 create-volume --availability-zone eu-west-3a --iops 1337 --size 100 --volume-type io1
{
    "AvailabilityZone": "eu-west-3a",
    "CreateTime": "2023-05-04T12:30:04+00:00",
    "Encrypted": false,
    "Size": 100,
    "SnapshotId": "",
    "State": "creating",
    "VolumeId": "vol-0cba6d099003264f2",
    "Iops": 1337,
    "Tags": [],
    "VolumeType": "io1",
    "MultiAttachEnabled": false
}

The documentation updated by #1409 is also already mentioning that iopPerGB or iops can be used for io1 volumes but it's today impossible to use the iops key because of this condition.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: surian / name: Christophe-Alexandre Ferriol (b3f6c6c)

[k8s-ci-robot]

Welcome @surian!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @surian. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[torredil]

/ok-to-test

[surian]

/retest

[ConnorJC3]

/lgtm

[rdpsin]

Can we add a test to check for success when using io1/io2 volume with no iopsPerGb parameter?

[surian]

I added 2 tests (one for io1, one for io2) to check for success when iops parameter is used instead of iopspergb.

[surian]

/retest

[ConnorJC3]

/retest

flaky test

Could you please squash your commits? Other than that, this PR looks good to me as written.

[rdpsin]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rdpsin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rdpsin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ConnorJC3]

/hold

needs squash

[surian]

Could you please squash your commits? Other than that, this PR looks good to me as written.

Done 👍

[torredil]

Thanks!
/unhold