Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old coverage banner from README #1617

Merged
merged 1 commit into from
May 26, 2023

Conversation

jacobwolfaws
Copy link
Contributor

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?
Remove the coverage banner from the README. The banner points to this link: https://coveralls.io/github/kubernetes-sigs/aws-ebs-csi-driver?branch=master, which is of 2 year old testing that doesn't seem to be supported anymore. It's been removed from the FSx Lustre CSI Driver
What testing is done?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2023
@k8s-ci-robot k8s-ci-robot requested a review from gtxu May 26, 2023 14:10
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 26, 2023
@hanyuel
Copy link
Contributor

hanyuel commented May 26, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2023
@rdpsin
Copy link
Contributor

rdpsin commented May 26, 2023

/retest

1 similar comment
@jacobwolfaws
Copy link
Contributor Author

/retest

@rdpsin
Copy link
Contributor

rdpsin commented May 26, 2023

/retest

@torredil
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 31c6df4 into kubernetes-sigs:master May 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants