Add 15 second rate limit to CreateSnapshot

[ConnorJC3]

Is this a bug fix or adding new feature?

Bug fix

What is this PR about? / Why do we need it?

See #1608
See kubernetes-csi/external-snapshotter#778

Adds a 15 second rate limit to CreateSnapshot when the failure originates from CreateSnapshot in cloud (i.e. the error likely originates from the AWS API).

This prevents the driver from getting stuck in an infinite loop if snapshot creation fails, where it will indefinately retry creating a snapshot and continue to receive an error because it is going too fast.

What testing is done?

Manual/CI/Inflight already has unit tests

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from connorjc3. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@ConnorJC3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows	56c9407	link	false	/test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[hanyuel]

The change in this PR is identical to #1611 . What was the reason we need a new PR?

[hanyuel]

The change in this PR is identical to #1611 . What was the reason we need a new PR?

Never mind. I figured out it's because both are merging from the same branch.

[ConnorJC3]

To give more context, #1611 was created on a previous version of this change, but this methodology differs so drastically from the version that @rdpsin reviewed in #1611 that I figured starting fresh with a new PR was the appropriate choice.

This PR supersedes and replaces #1611.

[torredil]

This PR can be closed now that kubernetes-csi/external-snapshotter#871 has (hopefully) been fixed.

[ConnorJC3]

/close

[k8s-ci-robot]

@ConnorJC3: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.