Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick release-1.23] Add compatibility workaround for A1 instance family #1811

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

ConnorJC3
Copy link
Contributor

/assign @AndrewSirenko

Signed-off-by: Connor Catlett <conncatl@amazon.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2023
@AndrewSirenko
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2853e09 into kubernetes-sigs:release-1.23 Oct 27, 2023
15 checks passed
@calvinbui
Copy link

will there be any workarounds for v1.25 or v1.26? the helm chart with a1CompatibilityDaemonSet=true tries to pull the v1.26.0-a1compat tag which doesn't exist.

@AndrewSirenko
Copy link
Contributor

AndrewSirenko commented Dec 27, 2023

Hi @calvinbui, thank you for reaching out about a1compat for v1.25 and 1.26.

I have been working with EKS to try to find out why public.ecr.aws/ebs-csi-driver/aws-ebs-csi-driver:v1.25.0-a1compat and public.ecr.aws/ebs-csi-driver/aws-ebs-csi-driver:v1.26.0-a1compat don't exist. I will update you later today (by 8pm EST).

If you urgently need to unblock yourself, you can try replacing the default ecr-public image repository with registry.k8s.io/provider-aws/aws-ebs-csi-driver

The registry.k8s.io/provider-aws/aws-ebs-csi-driver:v1.26.0-a1compat image exists.

❯ crane manifest registry.k8s.io/provider-aws/aws-ebs-csi-driver:v1.26.0-a1compat
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
  "config": {
    "mediaType": "application/vnd.docker.container.image.v1+json",
    "digest": "sha256:f685b489fffdf1c10d0c82d535d138abf6ab84edaaa3a13cd48d930990682352",
    "size": 1637
  },
  "layers": [
    ...
  ]
}

@AndrewSirenko
Copy link
Contributor

Hi @calvinbui, the a1 compat images are available on ecr-public now Amazon ECR Public Gallery - EBS CSI driver/aws-ebs-csi-driver

❯ crane digest public.ecr.aws/ebs-csi-driver/aws-ebs-csi-driver:v1.26.0-a1compat
sha256:aff5fff2f34664b2e450794cc050a9834a61ff25fe90b5846252efcf7b817b53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants