Update getvolumeslimit #1859
Merged
Update getvolumeslimit #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
Code Coverage Diff
|
… limit Signed-off-by: Eddie Torres <torredil@amazon.com>
Signed-off-by: Eddie Torres <torredil@amazon.com>
torredil
force-pushed
the
update-getvolumeslimit
branch
from
9fe0058
to
c01d2fe
Compare
|
cc: @jsafrane |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
AndrewSirenko
approved these changes
Dec 11, 2023
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about? / Why do we need it?
This PR:
availableAttachmentsto a value of 1 in cases where it is calculated to be <= 0. This value is currently clamped to 0 when the undercounting behavior is observed as a result of the unreliable block device mappings count, which the scheduler treats as "infinity". Continuing to schedule stateful pods on instances which are already at capacity is very undesirable. Previously, cluster operators could observe the following error:which is more helpful. Reporting a value of 1 is safer when erring on the side of caution.
What testing is done?
make test