Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-stop LCH enhancements #1895

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Pre-stop LCH enhancements #1895

merged 3 commits into from
Jan 18, 2024

Conversation

torredil
Copy link
Member

@torredil torredil commented Jan 12, 2024 •
edited

What is this PR about? / Why do we need it?

This PR:

  • Updates event handler associated with VolumeAttachment object informer.
  • Updates csi-node clusterrole RBAC rules for volume attachments to include get, watch, and update.
  • Removes context timeout handling from preStop LCH - let terminationGracePeriodSeconds in the pod specification define the upper bound for timeout instead.

see #1665 for context.

What testing is done?

make test

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2024
@torredil
Copy link
Member Author

/retest

@torredil torredil marked this pull request as draft January 12, 2024 21:34
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 17, 2024
@torredil torredil marked this pull request as ready for review January 17, 2024 00:40
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2024
@github-actions GitHub Actions
Copy link

Code Coverage Diff

File Old Coverage New Coverage Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/cmd/hooks/prestop.go 91.8% 82.4% -9.5

@torredil torredil force-pushed the lch-rbac branch 3 times, most recently from 7bec284 to f63a5b0 Compare January 17, 2024 14:00
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2024
AndrewSirenko
AndrewSirenko approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than Connor's change + possibly editing that comment.

cmd/hooks/prestop.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2024
@torredil
Update csi-node clusterrole RBAC rules for volumeattachments
58c746d 
Signed-off-by: Eddie Torres <torredil@amazon.com>
@torredil
Update event handlers for volume attachment informer
c1d5eff 
Signed-off-by: Eddie Torres <torredil@amazon.com>
@torredil
Remove preStop LCH context timeout
670c683 
Signed-off-by: Eddie Torres <torredil@amazon.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2024
@torredil
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@torredil torredil mentioned this pull request Jan 18, 2024
Closed
@k8s-ci-robot k8s-ci-robot merged commit 889b1e4 into kubernetes-sigs:master Jan 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 ConnorJC3 left review comments

@AndrewSirenko AndrewSirenko AndrewSirenko approved these changes

Assignees

@AndrewSirenko AndrewSirenko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@torredil @k8s-ci-robot @ConnorJC3 @AndrewSirenko