Batch EC2 DescribeSnapshots #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
Code Coverage Diff
|
AndrewSirenko
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold Holding until we decide on Snapshot scalability tests. |
k8s-ci-robot
added
the
do-not-merge/hold
AndrewSirenko
force-pushed
the
batch-snap
branch
from
d2dc135
to
09fc730
Compare
AndrewSirenko
force-pushed
the
batch-snap
branch
from
09fc730
to
08b0318
Compare
AndrewSirenko
commented
Mar 7, 2024
ConnorJC3
reviewed
Mar 11, 2024
torredil
approved these changes
Mar 11, 2024
k8s-ci-robot
added
the
lgtm
AndrewSirenko
force-pushed
the
batch-snap
branch
from
08b0318
to
d842488
Compare
k8s-ci-robot
removed
the
lgtm
AndrewSirenko
force-pushed
the
batch-snap
branch
from
d842488
to
3cdea89
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
Coalesces EC2 DescribeSnapshots calls across CreateSnapshot/DeleteSnapshot/ListSnapshots RPCs by Snapshot ID or by tag.
This decreases the likelihood of being exceeding one's Non-mutating API request token limit when creating many snapshots at once, which may impact all driver RPCs (ie being throttled for making too many
Describe*calls).What testing is done?
Manual testing on modified Volume Snapshots example to check that calls were batched.
TODO manual testing on ListSnapshots RPC.
possible snapshot scalability test. We would tune snapshot batcherOffline decided to start with conservative maxDelay, and tune once snapshot scalability tests are prioritized.maxDelays based on these tests.CI