Return ErrInvalidArgument in cloud upon EC2 ModifyVolume

[AndrewSirenko]

Is this a bug fix or adding new feature?
Feature

What is this PR about? / Why do we need it?
Today, if a user changes the VolumeAttributeClass of a PVC to one that is infeasible (i.e. volume type gp7), the external-resizer will immediately and continuously resend the infeasible request (with backoff). This leads to wasted work by the driver/k8s API and possible EC2 API throttling.

In order to fix this, ebs-plugin must report an INVALID_ARGUMENT gRPC error code to the external-resizer when the VAC could never be possible, so that the external-resizer marks status as infeasible and re-queues the request with a much longer backoff (as shown by This VolumeAttributesClass-ModifyVolume-Flow diagram.

Note: As of today, it seems that external-resizer modifycontroller may have a bug or incomplete infeasible status implementation, because the RPC is not re-queued with a much longer backoff. I will create an issue about this after diving a bit deeper. We should still make this change so that the driver will support this infeasible backoff behavior once resizer is fixed.

What testing is done?

Following our modify-volume via VAC example and

• Observing no error when following example as normal
• Observe InvalidArgument code upon the following EC2 errors:
  • InvalidParameterCombination
  • InvalidParameterValue (e.g. "Iops to volume size ratio too high")
  • UnknownVolumeType
• CI

ebs-plugin logs:

I0308 15:25:46.621027       1 controller.go:622] "ControllerModifyVolume: called" args={"volume_id":"vol-04adf19caca0175da","mutable_parameters":{"iops":"10000","type":"io3"}}                                                          │
│ I0308 15:25:46.621056       1 controller_modify_volume.go:124] "Start processing ModifyVolumeRequest for " volume ID="vol-04adf19caca0175da"                                                                                             │
...                                                                                                                                                          │
│ I0308 15:25:48.621504       1 cloud.go:632] "Received Modify Disk request" volumeID="vol-04adf19caca0175da" options={"VolumeType":"io3","IOPS":10000,"Throughput":0}                                                                     │

...                                                                                                                                               │
│ E0308 15:25:49.875113       1 driver.go:156] "GRPC error" err=<                                                                                                                                                                          │
│     rpc error: code = InvalidArgument desc = Could not modify volume "vol-04adf19caca0175da": invalid argument: UnknownVolumeType: Unsupported volume type 'io3' for volume creation.                                                    │
│         status code: 400, request id: 9b0bb059-ca73-4afa-9ca3-ee9420797ae6                                                                                                                                                               │
│  >

[github-actions]

Code Coverage Diff

File	Old Coverage	New Coverage	Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/cloud/cloud.go	82.9%	82.5%	-0.4
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/controller_modify_volume.go	86.2%	85.4%	-0.8

[ConnorJC3]

/lgtm

[torredil]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [torredil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[torredil]

/retest