Fix relationship between node service and mounter interface #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Code Coverage Diff
|
torredil
force-pushed
the
csi-refactor-mounter-node-v2
branch
3 times, most recently
from
7e4089b
to
b090dc2
Compare
|
/retest |
torredil
force-pushed
the
csi-refactor-mounter-node-v2
branch
from
b090dc2
to
bd4b87d
Compare
|
/retest |
k8s-ci-robot
added
the
needs-rebase
torredil
force-pushed
the
csi-refactor-mounter-node-v2
branch
from
f974271
to
a993baa
Compare
k8s-ci-robot
removed
the
needs-rebase
ConnorJC3
reviewed
Apr 16, 2024
torredil
force-pushed
the
csi-refactor-mounter-node-v2
branch
2 times, most recently
from
edf4395
to
88e5cd6
Compare
torredil
force-pushed
the
csi-refactor-mounter-node-v2
branch
2 times, most recently
from
f3da9b4
to
5d75342
Compare
k8s-ci-robot
added
the
lgtm
Signed-off-by: torredil <torredil@amazon.com>
torredil
force-pushed
the
csi-refactor-mounter-node-v2
branch
from
5d75342
to
fe51533
Compare
k8s-ci-robot
removed
the
lgtm
AndrewSirenko
approved these changes
Apr 16, 2024
k8s-ci-robot
added
the
lgtm
|
/approve Thank you very much for all of the great effort in reviewing all the changes made across the refactoring PRs @ConnorJC3 @AndrewSirenko |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about? / Why do we need it?
This patch is 2/2, designed to improve the architecture of the code base with the goal of promoting a more cohesive and understandable design that makes it easier to reason about the driver and make future modifications or extensions more intuitive.
More specifically, this PR fixes the relationship between the node service and mounter interface, allowing for a platform agnostic node service.
Summary of Changes
resizeFsfunctionality into mounter packageNodeStageVolumeandNodeExpandVolumeRPCs to use theResizemethod directly from theMounterinterface, instead of creating a newResizeFsinstance.DeviceIdentifierinterfacedeviceIdentifierwith direct calls toos.Lstatandfilepath.EvalSymlinks.node_linux.goandnode_windows.gotomount_linux.goandmount_windows.go.metadata.MetadataService,Mounter,metadata.KubernetesAPIClient) into theNewDriver()andNewNodeService()functions.What testing is done?
make test && make verify