Makefile & hack/ Process Improvements
#2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Code Coverage DiffThis PR does not change the code coverage |
ConnorJC3
force-pushed
the
faster-clusters
branch
2 times, most recently
from
e070430
to
86e1f46
Compare
…ion in config.sh Signed-off-by: Connor Catlett <conncatl@amazon.com>
…of cluster name collisions in CI Signed-off-by: Connor Catlett <conncatl@amazon.com>
Signed-off-by: Connor Catlett <conncatl@amazon.com>
…or CI Signed-off-by: Connor Catlett <conncatl@amazon.com>
Signed-off-by: Connor Catlett <conncatl@amazon.com>
Signed-off-by: Connor Catlett <conncatl@amazon.com>
AndrewSirenko
approved these changes
May 1, 2024
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
"New Feature"
What is this PR about? / Why do we need it?
This PR is split into several much smaller commits:
Move WINDOWS and WINDOWS_HOSTPROCESS out of Makefile to correct location in config.sh
Small fix to remove unnecessary variables in the
Makefile.Use Prow BUILD_ID in CI jobs if present to greatly reduce the chance of cluster name collisions in CI
Prow jobs have a random chance of colliding because
$RANDOMis only a 4 digit number (You'd think it's 1/10000 but it's much higher than that because of the Birthday Paradox).Use
$BUILD_IDin CI which is guaranteed to be unique. Had to cut off a little bit of the beginning of the name to make it short enough foreksctl.Add make cluster/kubeconfig
Convenience command for local development, used to set the
KUBECONFIGfor the cluster created bymake cluster/create.Add make cluster/image command; Build image and cluster in parallel for CI
Parallelize building the image and creating the cluster on CI, had to split image build out into a separate command to do this.
Breaking change for contributors:
make cluster/e2estyle commands no longer build the image, you must either runmake cluster/imagefirst or bring your own image.Template eksctl cluster file so Windows nodegroup can build in parallel
Parallelize creating the Linux and Windows nodegroup for
eksctlclusters by using a cluster file instead ofeksctlcommands.Parallelize kubetest2 installation in CI
kubetest2takes surprisingly long to install, might as well do so while building the cluster/image already.What testing is done?
CI/Manual