add namespaceOverride support

[RuStyC0der]

PR regarding issue #2050

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: RuStyC0der / name: Maksim Sagan (fc6203a, bb99048, 832c923, 8fd2da8, cca967f, e1d2bd0)
• ✅ login: ConnorJC3 / name: ConnorJC (d7b91e6)
• ✅ login: AndrewSirenko / name: Drew Sirenko (9682bfe)

[k8s-ci-robot]

Welcome @RuStyC0der!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @RuStyC0der. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[torredil]

/ok-to-test

[torredil]

Thank you for the contribution!

/lgtm

[AndrewSirenko]

Will lgtm after nits. Thank you!

[ConnorJC3]

Please also add the changes from _node.tpl to _node-windows.tpl - Otherwise lgtm

Edit: Also, you'll have to rebase your PR after we fix the govulncheck issue, will let you know when that's ready

[github-actions]

Code Coverage Diff

This PR does not change the code coverage

[RuStyC0der]

also found out that ebs-csi-node-getter-binding needs namespace override support to get properly bound

[rdpsin]

Can you squash your commits into one? Thanks.

[AndrewSirenko]

/label tide/merge-method-squash

Can you squash your commits into one?

Prow got some upgrades @rdpsin 😄

[ConnorJC3]

Unfortunately, you will need to rebase on top of the latest master to make govulncheck happy - once you do that we can merge this in.

[RuStyC0der]

Hi @ConnorJC3, just rebased master commits)

[RuStyC0der]

/test pull-aws-ebs-csi-driver-external-test-arm64

[AndrewSirenko]

/lgtm

[RuStyC0der]

Hi, if there is no more issues, shall we get this PR merged?

[ConnorJC3]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ConnorJC3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RuStyC0der]

Thank all you guys for reviewing this PR) Hope my small enhancement will be useful)