Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest for Kubernetes 1.15 #322

Merged

Conversation

jsafrane
Copy link
Contributor

What is this PR about? / Why do we need it?
deploy/kubernetes does not work since Kubernetes 1.14:

  • The cluster-driver-registrar sidecar container was not released in 1.14 and the version from 1.13 does not work. It is now formally deprecated, so create CSIDriver instance during installation.
  • Bumped image versions to 1.15.
  • Fixed also couple of issues with the yaml file along the way.

The sidecar container is deprecated. CSIDriver instance must be created
manually instead
@k8s-ci-robot
Copy link
Contributor

Welcome @jsafrane!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 696

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.308%

Totals Coverage Status
Change from base Build 695: 0.0%
Covered Lines: 1178
Relevant Lines: 1652

💛 - Coveralls

@leakingtapan
Copy link
Contributor

deploy/kubernetes does not work since Kubernetes 1.14

Could you clarify on what is not working on 1.14? I have e2e tests testing against 1.14, and don't find any obvious issue.

- name: csi-provisioner
image: quay.io/k8scsi/csi-provisioner:v1.1.0
image: quay.io/k8scsi/csi-provisioner:v1.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change compatible with k8s 1.14? We are planing to do a 0.4 release with is supposed to be compatible with 1.14. So don't want to break the driver on 1.14

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes docs claim that 1.3.0 works with 1.14
https://kubernetes-csi.github.io/docs/external-provisioner.html

@@ -193,7 +155,7 @@ spec:
- name: socket-dir
mountPath: /var/lib/csi/sockets/pluginproxy/
- name: csi-attacher
image: quay.io/k8scsi/csi-attacher:v1.1.0
image: quay.io/k8scsi/csi-attacher:v1.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above question

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsafrane
Copy link
Contributor Author

Could you clarify on what is not working on 1.14

As I wrote above, cluster-driver-registrar sidecar container was not released in 1.14 and the version from 1.13 does not work. It most probably does not create CSIDriver instance.

@leakingtapan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2019
@leakingtapan
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jsafrane,leakingtapan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leakingtapan
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit e727882 into kubernetes-sigs:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants