Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running multi-az e2e test using Nitro instance #337

Merged
merged 1 commit into from Aug 14, 2019
Merged

Running multi-az e2e test using Nitro instance #337

merged 1 commit into from Aug 14, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
Fixes: #237

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 11, 2019
@coveralls
Copy link

coveralls commented Aug 11, 2019 •
edited

Pull Request Test Coverage Report for Build 734

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.308%
Totals Coverage Status
Change from base Build 728: 0.0%
Covered Lines: 1178
Relevant Lines: 1652
💛 - Coveralls

@bertinatto
Copy link
Member

LGTM. Could you elaborate what's the reasoning behind this change?

@leakingtapan
Copy link
Contributor Author

leakingtapan commented Aug 13, 2019 •
edited

@bertinatto this is for testing the nvme volume on Nitro instance. The idea is running the mult-az e2e test on the work nodes with c5 instance type. If the e2e test pass, it means nvme is supported

@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan
Copy link
Contributor Author

merge manually due to coverall outage

@leakingtapan leakingtapan merged commit 3bdb76d into kubernetes-sigs:master Aug 14, 2019
@leakingtapan leakingtapan deleted the nvme branch August 14, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add nvme e2e test
4 participants
@leakingtapan @k8s-ci-robot @coveralls @bertinatto