Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github workflow to build and publish container image #383

Merged
merged 1 commit into from Oct 3, 2019
Merged

Add github workflow to build and publish container image #383

merged 1 commit into from Oct 3, 2019

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
Add github workflow to build and publish container image:

  • It publishes to both dockerhub and github registry
  • It uses latest tag for master branch and version tag for git tag (release)
  • It only triggers when *.go files are changed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2019
@leakingtapan
Copy link
Contributor Author

/cc @M00nF1sh

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 3, 2019
@coveralls
Copy link

coveralls commented Oct 3, 2019 •
edited

Pull Request Test Coverage Report for Build 872

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.972%
Totals Coverage Status
Change from base Build 863: 0.0%
Covered Lines: 1176
Relevant Lines: 1657
💛 - Coveralls

@leakingtapan leakingtapan force-pushed the workflow branch 2 times, most recently from 85ac1e9 to 7963006 Compare October 3, 2019 05:15
Add github workflow to build and publish container image
7565fd8 
It publishes to both dockerhub and github registry
@leakingtapan leakingtapan merged commit cc632b7 into kubernetes-sigs:master Oct 3, 2019
@leakingtapan leakingtapan deleted the workflow branch October 3, 2019 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

@d-nishi d-nishi Awaiting requested review from d-nishi

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leakingtapan @k8s-ci-robot @coveralls