Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #391

Merged
merged 3 commits into from Oct 31, 2019
Merged

Update README #391

merged 3 commits into from Oct 31, 2019

Conversation

leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Oct 15, 2019 •
edited

Is this a bug fix or adding new feature?
Update README
remove the notes since it is officially supported by EKS

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 15, 2019
@coveralls
Copy link

coveralls commented Oct 15, 2019 •
edited

Pull Request Test Coverage Report for Build 891

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.273%
Totals Coverage Status
Change from base Build 884: 0.0%
Covered Lines: 1176
Relevant Lines: 1650
💛 - Coveralls

@leakingtapan
Copy link
Contributor Author

/cc @wongma7

@leakingtapan
Copy link
Contributor Author

Some dependency issue with ec2:

Validation Failed
Using cluster from kubectl context: test-cluster-9641.k8s.local


error reading cluster configuration: error reading cluster configuration "test-cluster-9641.k8s.local": error reading s3://k8s-kops-csi-e2e/test-cluster-9641.k8s.local/config: Unable to list AWS regions: RequestError: send request failed
caused by: Post https://ec2.us-east-1.amazonaws.com/: net/http: TLS handshake timeout
Using cluster from kubectl context: test-cluster-9641.k8s.local


error reading cluster configuration: error reading cluster configuration "test-cluster-9641.k8s.local": error reading s3://k8s-kops-csi-e2e/test-cluster-9641.k8s.local/config: Unable to list AWS regions: RequestError: send request failed
caused by: Post https://ec2.us-east-1.amazonaws.com/: net/http: TLS handshake timeout
2019/10/16 00:01:57 Up failed: cluster is not created after 15m0s
2019/10/16 00:01:57 Deleting cluster test-cluster-9641.k8s.local

/retest

@wongma7
Copy link
Contributor

wongma7 commented Oct 16, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2019
@leakingtapan
Copy link
Contributor Author

/retest

7 similar comments
@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-integration

@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-integration

1 similar comment
@leakingtapan
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-integration

@leakingtapan
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2019
@leakingtapan
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2019
@leakingtapan leakingtapan merged commit a76801e into kubernetes-sigs:master Oct 31, 2019
@leakingtapan leakingtapan deleted the readme branch October 31, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-nishi d-nishi Awaiting requested review from d-nishi

@ddebroy ddebroy Awaiting requested review from ddebroy

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leakingtapan @k8s-ci-robot @coveralls @wongma7