Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e test #468

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Fix e2e test #468

merged 1 commit into from
Mar 21, 2020

Conversation

leakingtapan
Copy link
Contributor

Is this a bug fix or adding new feature?
To fix e2e test failures.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2020
@coveralls
Copy link

coveralls commented Mar 21, 2020 •
edited

Pull Request Test Coverage Report for Build 1043

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.43%
Totals Coverage Status
Change from base Build 1031: 0.0%
Covered Lines: 1386
Relevant Lines: 1790
💛 - Coveralls

@leakingtapan leakingtapan force-pushed the fix-build branch 2 times, most recently from f963c66 to 7154c73 Compare March 21, 2020 03:33
@leakingtapan leakingtapan changed the title Ping to fsnotify 1.4.7 Fix e2e test Mar 21, 2020
@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan leakingtapan mentioned this pull request Mar 21, 2020
Merged
@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan leakingtapan merged commit ba854a0 into kubernetes-sigs:master Mar 21, 2020
@leakingtapan leakingtapan deleted the fix-build branch March 21, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy Awaiting requested review from ddebroy

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leakingtapan @k8s-ci-robot @coveralls