Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct golint warning #478

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Correct golint warning #478

merged 1 commit into from
Apr 13, 2020

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Apr 5, 2020 •
edited 

aws-ebs-csi-driver/pkg/driver/controller.go
Line 418: warning: if block ends with a return statement, so drop this else and outdent its block (golint)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @gliptak. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1060

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 77.418%
Totals Coverage Status
Change from base Build 1057: -0.01%
Covered Lines: 1385
Relevant Lines: 1789
💛 - Coveralls

@gliptak
Copy link
Contributor Author

gliptak commented Apr 6, 2020 •
edited

@bertinatto @wongma7 please /ok-to-test

@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2020
@leakingtapan
Copy link
Contributor

Please update the description with what’s the lint error being fixed here? And I’m curious why the lint error isn’t showing as part of the prow job ?

@gliptak
Copy link
Contributor Author

gliptak commented Apr 10, 2020

@leakingtapan updated description

I cannot speak to prow (rules)

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 10, 2020
@leakingtapan
Copy link
Contributor

/retest

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gliptak, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gliptak
Copy link
Contributor Author

gliptak commented Apr 12, 2020

@leakingtapan would coverage decrease prevent this from merging?

@leakingtapan
Copy link
Contributor

Seems the coverage drop is not related to ur change. I will just merge it. Thx for the fix!

@leakingtapan leakingtapan merged commit d7c0077 into kubernetes-sigs:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@leakingtapan leakingtapan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gliptak @k8s-ci-robot @coveralls @leakingtapan