Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mount unittest #481

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Add mount unittest #481

merged 1 commit into from
Apr 11, 2020

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Apr 5, 2020

Signed-off-by: Gábor Lipták gliptak@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @gliptak. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 5, 2020
@coveralls
Copy link

coveralls commented Apr 5, 2020 •
edited

Pull Request Test Coverage Report for Build 1069

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.2%) to 78.659%
Totals Coverage Status
Change from base Build 1067: 1.2%
Covered Lines: 1408
Relevant Lines: 1790
💛 - Coveralls

@gliptak
Copy link
Contributor Author

gliptak commented Apr 6, 2020

@leakingtapan @ddebroy please /ok-to-test

@leakingtapan
Copy link
Contributor

thx for the PR!
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2020
@gliptak
Copy link
Contributor Author

gliptak commented Apr 7, 2020

/test pull-aws-ebs-csi-driver-e2e-single-az

@gliptak
Copy link
Contributor Author

gliptak commented Apr 7, 2020

@leakingtapan PR is green

leakingtapan
leakingtapan reviewed Apr 10, 2020
View reviewed changes
pkg/driver/mount_test.go Outdated Show resolved Hide resolved
pkg/driver/mount_test.go Show resolved Hide resolved
pkg/driver/mount_test.go Show resolved Hide resolved
@gliptak
Add mount unittest
1d7332e 
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@gliptak
Copy link
Contributor Author

gliptak commented Apr 10, 2020

/test pull-aws-ebs-csi-driver-e2e-single-az

@gliptak
Copy link
Contributor Author

gliptak commented Apr 11, 2020

@leakingtapan PR is green

@leakingtapan
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gliptak, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit c6749e6 into kubernetes-sigs:master Apr 11, 2020
@gliptak gliptak deleted the coverage1 branch April 11, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leakingtapan leakingtapan leakingtapan left review comments

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@leakingtapan leakingtapan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gliptak @k8s-ci-robot @coveralls @leakingtapan