Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Try to) fix cloudbuild #659

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Dec 16, 2020

Is this a bug fix or adding new feature? fix cloudbuild.yaml

What is this PR about? / Why do we need it? the attempt to do multiarch cloudbuilds from #658 failed horribly with "Step #0: unknown flag: --tag". I think it has something to do with buildx not being available so I am shuffling that stray "HOME=/root" thing that I csopy/pasted from the doc to someplace that makes sense to me. Also sinc ethe github workflow has to enable multiarch using the qemu image then I guess this does too.

What testing is done?

docker run -e HOME=/root --entrypoint=bash -it  gcr.io/cloud-builders/docker
root@084b1a2e938b:/# DOCKER_CLI_EXPERIMENTAL=enabled docker buildx build --tag=gcr.io/k8s-staging-provider-aws/aws-ebs-csi-driver:latest .
[+] Building 0.0s (0/0)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2020
@ayberk
Copy link
Contributor

ayberk commented Dec 16, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1388

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.713%

Totals Coverage Status
Change from base Build 1386: 0.0%
Covered Lines: 1622
Relevant Lines: 1985

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot merged commit 7ad3e65 into kubernetes-sigs:master Dec 16, 2020
@wongma7
Copy link
Contributor Author

wongma7 commented Dec 16, 2020

Progress, but not there yet.

Step #1: "docker buildx build" requires exactly 1 argument.

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/aws-ebs-csi-driver-push-images/1339014979134689280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants