Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note for gp3 on outposts #665

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Add note for gp3 on outposts #665

merged 1 commit into from
Dec 18, 2020

Conversation

ayberk
Copy link
Contributor

@ayberk ayberk commented Dec 18, 2020

Is this a bug fix or adding new feature?
/kind documentation

What is this PR about? / Why do we need it?
Adding a note because gp3 is not supported on outposts. See #662

What testing is done?
N/A

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2020
@wongma7
Copy link
Contributor

wongma7 commented Dec 18, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1400

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.713%
Totals Coverage Status
Change from base Build 1391: 0.0%
Covered Lines: 1622
Relevant Lines: 1985
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot merged commit e0f4887 into kubernetes-sigs:master Dec 18, 2020
@ayberk ayberk deleted the patch-1 branch March 29, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ayberk @k8s-ci-robot @wongma7 @coveralls