Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call hack/prow.sh from cloudbuild #666

Merged
merged 1 commit into from
Dec 19, 2020

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Dec 18, 2020

Is this a bug fix or adding new feature? fix gcr builds

What is this PR about? / Why do we need it? gcr builds are broken in attempt to fix multiarch build.

I stopped short of migrating to csi-release-tools entirely, that would take more work. However I copied parts from it and linked to those parts.

What testing is done? Same as with previous PRs: Unfortunately I cannot test end-to-end without actually merging, the container release prow job runs on master and release* branches. I did briefly test the script on release-test branch with manual pushes before prow caught on and marked it protected....

Script works locally.
env REGISTRY_NAME=public.ecr.aws/b5w6x5z2 GIT_TAG=asdf ./hack/prow.sh

DEBIAN x86-64

$ sudo ctr image pull public.ecr.aws/b5w6x5z2/aws-ebs-csi-driver:asdf
$ sudo ctr run --net-host --rm -t public.ecr.aws/b5w6x5z2/aws-ebs-csi-driver:asdf asdf sh
# apt update && apt install file -y && file /bin/aws-ebs-csi-driver
/bin/aws-ebs-csi-driver: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=kAW_W3MP2F-SyISEkr-W/qEsEhwoBGlBqbFS0hG3t/REDBNNkQ3nfX4Tmp1I6c/V5-AYyKy-A6YG_3PdjzI, stripped

DEBIAN aarch64

$ sudo ctr image pull --platform linux/arm64 public.ecr.aws/b5w6x5z2/aws-ebs-csi-driver:asdf
$ sudo ctr run --platform linux/arm64 --net-host --rm -t public.ecr.aws/b5w6x5z2/aws-ebs-csi-driver:asdf asdf sh
# apt update && apt install file -y && file /bin/aws-ebs-csi-driver
/bin/aws-ebs-csi-driver: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=QvjkG7Q5dGFfqnCxoDs7/C0h4mNzh8pZyVakWrh8W/EJ8uqhT-5pYDQUP_FBMB/aFe_kvszu9EcCFF1EOUX, stripped

AL2 x86-64

$ sudo ctr image pull public.ecr.aws/b5w6x5z2/aws-ebs-csi-driver:asdf-amazonlinux
$ sudo ctr run --net-host --rm -t public.ecr.aws/b5w6x5z2/aws-ebs-csi-driver:asdf-amazonlinux asdf sh
sh-4.2# yum install file -y && file /bin/aws-ebs-csi-driver
/bin/aws-ebs-csi-driver: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped

AL2 aarch64

$ sudo ctr image pull --platform linux/arm64 public.ecr.aws/b5w6x5z2/aws-ebs-csi-driver:asdf-amazonlinux
$ sudo ctr run --platform linux/arm64 --net-host --rm -t public.ecr.aws/b5w6x5z2/aws-ebs-csi-driver:asdf-amazonlinux asdf sh
sh-4.2# yum install file -y && file /bin/aws-ebs-csi-driver
/bin/aws-ebs-csi-driver: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, stripped

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2020
@ayberk
Copy link
Contributor

ayberk commented Dec 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1403

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.713%

Totals Coverage Status
Change from base Build 1401: 0.0%
Covered Lines: 1622
Relevant Lines: 1985

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot merged commit 1bb8ba8 into kubernetes-sigs:master Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants