Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for storage class parameter - fsType #67

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Implement support for storage class parameter - fsType #67

merged 1 commit into from
Oct 18, 2018

Conversation

leakingtapan
Copy link
Contributor

Fixes: #62

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 16, 2018
@coveralls
Copy link

coveralls commented Oct 16, 2018 •
edited

Pull Request Test Coverage Report for Build 61

  • 5 of 11 (45.45%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 49.384%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/driver/node.go 0 6 0.0%
Totals Coverage Status
Change from base Build 60: 0.006%
Covered Lines: 521
Relevant Lines: 1055
💛 - Coveralls

bertinatto
bertinatto reviewed Oct 17, 2018
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit and a suggestion, but looks good to me.

(I'm not adding the lgtm label so you can change it before merging)

pkg/driver/node.go Outdated Show resolved Hide resolved
pkg/driver/node.go Outdated
attributes := req.GetVolumeAttributes()
fsType, exists = attributes["fsType"]
if !exists || fsType == "" {
fsType = "ext4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest making this a constant, e.g., defaultFileSystem and adding some documentation about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@bertinatto
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit fa5a43c into kubernetes-sigs:master Oct 18, 2018
@leakingtapan leakingtapan deleted the sc-fs-type branch October 30, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@bertinatto bertinatto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leakingtapan @k8s-ci-robot @coveralls @bertinatto