Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate external e2e test in the testsuits #726

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

AndyXiangLi
Copy link
Contributor

Is this a bug fix or adding new feature?
Fixes #470
What is this PR about? / Why do we need it?
Set up environment to run external e2e test from here
Integrate with CI to make external test a required step: kubernetes/test-infra#20747

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @AndyXiangLi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 5, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1553

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.196%

Totals Coverage Status
Change from base Build 1551: 0.0%
Covered Lines: 1697
Relevant Lines: 2090

💛 - Coveralls

@wongma7
Copy link
Contributor

wongma7 commented Feb 5, 2021

/test pull-migration-latest

@k8s-ci-robot
Copy link
Contributor

@wongma7: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-aws-ebs-csi-driver-verify
  • /test pull-aws-ebs-csi-driver-unit
  • /test pull-aws-ebs-csi-driver-e2e-single-az
  • /test pull-aws-ebs-csi-driver-e2e-multi-az
  • /test pull-aws-ebs-csi-driver-migration-test-latest

Use /test all to run the following jobs:

  • pull-aws-ebs-csi-driver-verify
  • pull-aws-ebs-csi-driver-unit
  • pull-aws-ebs-csi-driver-e2e-single-az
  • pull-aws-ebs-csi-driver-e2e-multi-az

In response to this:

/test pull-migration-latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wongma7
Copy link
Contributor

wongma7 commented Feb 5, 2021

/test pull-aws-ebs-csi-driver-migration-test-latest

@wongma7
Copy link
Contributor

wongma7 commented Feb 5, 2021

/ok-to-test
/approve

Triggered a migration test just to make sure make rule works still. (obviously it should, it's just a file rename). I don't expect it to actually pass though (known issue), just want to see that the tests execute.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndyXiangLi, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
@wongma7
Copy link
Contributor

wongma7 commented Feb 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@AndyXiangLi
Copy link
Contributor Author

/retest

@AndyXiangLi
Copy link
Contributor Author

/test all

@k8s-ci-robot
Copy link
Contributor

@AndyXiangLi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-aws-ebs-csi-driver-migration-test-latest 6d2e79c link /test pull-aws-ebs-csi-driver-migration-test-latest

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wongma7
Copy link
Contributor

wongma7 commented Feb 5, 2021

I'll manually merge, didn't realize it would block!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Kubernetes e2e tests of the driver
4 participants