Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ECR overlay #745

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Update ECR overlay #745

merged 1 commit into from
Feb 12, 2021

Conversation

ayberk
Copy link
Contributor

@ayberk ayberk commented Feb 12, 2021

It's been a while since we updated the ECR overlay. This PR

  • Updates the driver version to 0.9.0
  • Uses the new public ECR for sidecars

What testing is done?
Deployed to my own cluster and verified it runs.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2021
@wongma7
Copy link
Contributor

wongma7 commented Feb 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1598

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.286%
Totals Coverage Status
Change from base Build 1596: 0.0%
Covered Lines: 1707
Relevant Lines: 2100
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot merged commit 85699e1 into kubernetes-sigs:master Feb 12, 2021
@ayberk ayberk deleted the ecr_overlay branch February 12, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-nishi d-nishi Awaiting requested review from d-nishi

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ayberk @k8s-ci-robot @wongma7 @coveralls