Fix broken gomocks #843
Merged
Fix broken gomocks #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XXL
Pull Request Test Coverage Report for Build 1870
💛 - Coveralls |
wongma7
force-pushed
the
fixmocks
branch
2 times, most recently
from
d635f51
to
5e18df5
Compare
k8s-ci-robot
added
size/XL
|
/retest i got it working locally (finally) but ci seems upset by my pushes |
vdhanan
approved these changes
Apr 21, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdhanan, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature? fikx
What is this PR about? / Why do we need it? hack/update-gomock (make mockgen) is broken atm, seeing if this fixes it.
What testing is done? script works locally, not surei f the newly generated mocks break tests or anything , let CI test it.