Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop pushing latest tag and remove all references to it #949

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Stop pushing latest tag and remove all references to it #949

merged 1 commit into from
Jun 30, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Jun 22, 2021

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?

  • using latest tag is not recommended, users should pin to a version
  • the make rules are obsolete because github/prow jobs automate pushing. They might be useful for dev testing but personally I do not think they are useful, I rather just call docker build/push directly.
  • Docker Hub has latest tags but community GCR doesn't support mutable tags . So to be consistent, we should just not push latest anywhere.

What testing is done?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2021
@nckturner
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5f7fc35 into kubernetes-sigs:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees

@nckturner nckturner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wongma7 @k8s-ci-robot @nckturner