Install snapshot controller independently of helm for e2e tests #968
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
error: error creating cluster: [spec.snapshotController.enabled: Forbidden: Snapshot controller requires that cert manager is enabled, spec.snapshotController.enabled: Forbidden: Snapshot controller requires external CSI Driver] hmm, this is disappointing |
|
So as a kops user, if I want it to install snapshot controller, i must also have it install the driver for me. i.e. kops snapshot controller + helm ebs csi driver = invalid |
|
error listing SQS queues: AccessDenied: Access to the resource https://sqs.us-west-2.amazonaws.com/ is denied. what the heck? /retest |
|
/test pull-aws-ebs-csi-driver-e2e-single-az should have sqs permissions now. kubernetes/kops#11299 |
|
/retest |
hack/e2e/run.sh
Outdated
| @@ -144,6 +144,15 @@ elif [[ "${CLUSTER_TYPE}" == "eksctl" ]]; then | |||
| fi | |||
| fi | |||
|
|
|||
| if [[ "${EBS_INSTALL_SNAPSHOT}" == true ]]; then | |||
| loudecho "Installing snapshot controller and CRDs" | |||
| kubectl apply --kubeconfig "${KUBECONFIG}" -f https://raw.githubusercontent.com/kubernetes-csi/external-snapshotter/v4.1.1/deploy/kubernetes/snapshot-controller/rbac-snapshot-controller.yaml | |||
There was a problem hiding this comment.
It's ok to be hardcoding the snapshot-controller version here? Do we at least want to extract it into a variable to make it easier to change?
There was a problem hiding this comment.
fixed, made it variable
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
In preparation for removing snapshot controller installation from our helm chart #965, try using other methods to install it as a prerequisite.
upgrade kops to 1.21.0 and addsame as belowsnapshotController.enabled: trueto hack/kops-patch.yaml (the resources are embedded in kops, copied from external-snapshotter repo)What testing is done?