Address PR comments

kubernetes-sigs · Apr 28, 2021 · b1c989d · b1c989d
1 parent f634239
commit b1c989d
Show file tree

Hide file tree

Showing 4 changed files with 62 additions and 8 deletions.
diff --git a/charts/aws-efs-csi-driver/CHANGELOG.md b/charts/aws-efs-csi-driver/CHANGELOG.md
@@ -2,14 +2,68 @@
 
 # v2.0.0
 
-## Notable changes
+## Breaking changes
 
-* Multiple breaking changes in values file
-* Support only Kubernetes `>=1.18` with `CSIDriver` API version `storage.k8s.io/v1`
+Multiple changes in values file at `sidecars`, `controller` and `node`
+
+---
+
+```yaml
+sidecars:
+  xxxxxxImage:
+    repository:
+    tag:
+```
+
+Moving to
+
+```yaml
+sidecars:
+  xxxxxxImage:
+    image:
+      repository:
+      tag:
+```
+
+---
+
+```yaml
+hostAliases:
+dnsPolicy:
+dnsConfig:
+```
+
+Moving to
+
+```yaml
+node:
+  hostAliases:
+  dnsPolicy:
+  dnsConfig:
+```
+
+---
+
+```yaml
+serviceAccount:
+  controller:
+```
+
+Moving to
+
+```yaml
+controller:
+  serviceAccount:
+```
 
 ## New features
 
+* Set `resources` and `imagePullPolicy` fields independently for containers
 * Set `logLevel`, `affinity`, `nodeSelector`, `podAnnotations` and `tolerations` fields independently
 for Controller deployment and Node daemonset
-* Set `resources` and `imagePullPolicy` fields independently for containers
 * Set `reclaimPolicy` and `volumeBindingMode` fields in storage class
+
+## Fixes
+
+* Default `logLevel` lowered from `5` to `2`
+* Default `imagePullPolicy` everywhere set to `IfNotPresent`
diff --git a/charts/aws-efs-csi-driver/Chart.yaml b/charts/aws-efs-csi-driver/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v1
 name: aws-efs-csi-driver
 version: 2.0.0
 appVersion: "1.2.0"
-kubeVersion: ">=1.18.0-0"
+kubeVersion: ">=1.17.0-0"
 description: A Helm chart for AWS EFS CSI Driver
 home: https://github.com/kubernetes-sigs/aws-efs-csi-driver
 sources:

diff --git a/charts/aws-efs-csi-driver/templates/csidriver.yaml b/charts/aws-efs-csi-driver/templates/csidriver.yaml
@@ -1,4 +1,4 @@
-apiVersion: storage.k8s.io/v1
+apiVersion: {{ ternary "storage.k8s.io/v1" "storage.k8s.io/v1beta1" (semverCompare ">=1.18.0-0" .Capabilities.KubeVersion.Version) }}
 kind: CSIDriver
 metadata:
   name: efs.csi.aws.com

diff --git a/charts/aws-efs-csi-driver/values.yaml b/charts/aws-efs-csi-driver/values.yaml
@@ -40,7 +40,7 @@ controller:
   # Specifies whether a deployment should be created
   create: true
   # Number for the log level verbosity
-  logLevel: 5
+  logLevel: 2
   # Add additional tags to access points
   tags: {}
     # environment: prod
@@ -76,7 +76,7 @@ controller:
 
 node:
   # Number for the log level verbosity
-  logLevel: 5
+  logLevel: 2
   hostAliases:
     {}
     # for cross VPC EFS, you need to poison or overwrite the DNS for the efs volume as per