Skip to content

Commit

Permalink
Revert "Introduce Controller with Create and Delete Volume capability"
Browse files Browse the repository at this point in the history
This reverts commit f2fc7ce.
  • Loading branch information
wongma7 committed Jan 14, 2021
1 parent dfab855 commit e884215
Show file tree
Hide file tree
Showing 40 changed files with 1,056 additions and 3,639 deletions.
4 changes: 3 additions & 1 deletion .travis.yml
Expand Up @@ -13,5 +13,7 @@ before_install:

script:
- make
- go test -covermode=count -coverprofile=profile.cov ./pkg/...
- go test -covermode=count -coverprofile=profile.cov $(go list ./pkg/... | grep -v /driver)
# TODO stop skipping controller tests when controller is implemented
- go test -covermode=count -coverprofile=profile.cov ./pkg/driver/... -ginkgo.skip='\[Controller.Server\]'
- $GOPATH/bin/goveralls -coverprofile=profile.cov -service=travis-ci
4 changes: 3 additions & 1 deletion Makefile
Expand Up @@ -49,7 +49,9 @@ verify:

.PHONY: test
test:
go test -v -race ./pkg/...
go test -v -race $$(go list ./pkg/... | grep -v /driver)
# TODO stop skipping controller tests when controller is implemented
go test -v -race ./pkg/driver/... -ginkgo.skip='\[Controller.Server\]'

.PHONY: test-e2e
test-e2e:
Expand Down
4 changes: 1 addition & 3 deletions cmd/main.go
Expand Up @@ -39,8 +39,6 @@ func main() {
volMetricsOptIn = flag.Bool("vol-metrics-opt-in", false, "Opt in to emit volume metrics")
volMetricsRefreshPeriod = flag.Float64("vol-metrics-refresh-period", 240, "Refresh period for volume metrics in minutes")
volMetricsFsRateLimit = flag.Int("vol-metrics-fs-rate-limit", 5, "Volume metrics routines rate limiter per file system")
deleteAccessPointRootDir = flag.Bool("delete-access-point-root-dir", false,
"Opt in to delete access point root directory by DeleteVolume. By default, DeleteVolume will delete the access point behind Persistent Volume and deleting access point will not delete the access point root directory or its contents.")
)
klog.InitFlags(nil)
flag.Parse()
Expand All @@ -59,7 +57,7 @@ func main() {
if err != nil {
klog.Fatalln(err)
}
drv := driver.NewDriver(*endpoint, etcAmazonEfs, *efsUtilsStaticFilesPath, *volMetricsOptIn, *volMetricsRefreshPeriod, *volMetricsFsRateLimit, *deleteAccessPointRootDir)
drv := driver.NewDriver(*endpoint, etcAmazonEfs, *efsUtilsStaticFilesPath, *volMetricsOptIn, *volMetricsRefreshPeriod, *volMetricsFsRateLimit)
if err := drv.Run(); err != nil {
klog.Fatalln(err)
}
Expand Down
29 changes: 0 additions & 29 deletions deploy/kubernetes/base/clusterrole-provisioner.yaml

This file was deleted.

15 changes: 0 additions & 15 deletions deploy/kubernetes/base/clusterrolebinding-provisioner.yaml

This file was deleted.

81 changes: 0 additions & 81 deletions deploy/kubernetes/base/controller.yaml

This file was deleted.

4 changes: 0 additions & 4 deletions deploy/kubernetes/base/kustomization.yaml
Expand Up @@ -2,9 +2,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: kube-system
resources:
- clusterrole-provisioner.yaml
- clusterrolebinding-provisioner.yaml
- node.yaml
- csidriver.yaml
- controller.yaml
- serviceaccount-csi-controller.yaml
4 changes: 0 additions & 4 deletions deploy/kubernetes/base/node.yaml
Expand Up @@ -5,18 +5,14 @@ apiVersion: apps/v1
metadata:
name: efs-csi-node
namespace: kube-system
labels:
app.kubernetes.io/name: aws-efs-csi-driver
spec:
selector:
matchLabels:
app: efs-csi-node
app.kubernetes.io/name: aws-efs-csi-driver
template:
metadata:
labels:
app: efs-csi-node
app.kubernetes.io/name: aws-efs-csi-driver
spec:
nodeSelector:
kubernetes.io/os: linux
Expand Down
10 changes: 0 additions & 10 deletions deploy/kubernetes/base/serviceaccount-csi-controller.yaml

This file was deleted.

17 changes: 0 additions & 17 deletions deploy/kubernetes/overlays/dev/master_image.yaml
Expand Up @@ -3,23 +3,6 @@ apiVersion: apps/v1
metadata:
name: efs-csi-node
namespace: kube-system
labels:
app.kubernetes.io/name: aws-efs-csi-driver
spec:
template:
spec:
containers:
- name: efs-plugin
image: amazon/aws-efs-csi-driver:master
imagePullPolicy: Always
---
kind: Deployment
apiVersion: apps/v1
metadata:
name: efs-csi-controller
namespace: kube-system
labels:
app.kubernetes.io/name: aws-efs-csi-driver
spec:
template:
spec:
Expand Down
6 changes: 2 additions & 4 deletions go.mod
Expand Up @@ -3,10 +3,8 @@ module github.com/kubernetes-sigs/aws-efs-csi-driver
require (
github.com/aws/aws-sdk-go v1.31.2
github.com/container-storage-interface/spec v1.2.0
github.com/golang/mock v1.4.4
github.com/google/uuid v1.1.1
github.com/kubernetes-csi/csi-test v1.1.1
github.com/kubernetes-csi/csi-test/v3 v3.1.1 // indirect
github.com/golang/mock v1.4.3
github.com/kubernetes-csi/csi-test v2.2.0+incompatible
github.com/onsi/ginkgo v1.12.2
github.com/onsi/gomega v1.10.1
google.golang.org/grpc v1.26.0
Expand Down

0 comments on commit e884215

Please sign in to comment.