Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add watch dog for efs mount with stunnel #113

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Add watch dog for efs mount with stunnel #113

merged 1 commit into from
Dec 30, 2019

Conversation

leakingtapan
Copy link
Contributor

@leakingtapan leakingtapan commented Dec 16, 2019 •
edited

Is this a bug fix or adding new feature?
Fixes: #104

What is this PR about? / Why do we need it?

  • Add watch dog as subprocess of the driver
  • Add sub reaper to wait for stunnel processes
  • Add Dockerfile.dev. This helps with dev build of the container image by using driver binary built locally instead of multi stage container image build (which requires downloading all the dependencies)
  • Add unit test for watchdog and subreaper

What testing is done?
Tested manually with tls encryption example.
Verified that:

  • stunnel processes are killed after pod is deleted
  • stunnel processes are waited
  • efs watch dog is restarted after the watch dog process is killed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 16, 2019
@leakingtapan
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2019
mogren
mogren reviewed Dec 16, 2019
View reviewed changes
Copy link

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just had a few questions.

pkg/driver/efs_watch_dog.go Outdated Show resolved Hide resolved
pkg/driver/reaper.go Outdated Show resolved Hide resolved
pkg/driver/reaper.go Show resolved Hide resolved
@leakingtapan
Copy link
Contributor Author

/retest

1 similar comment
@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 29, 2019
Add watch dog as subprocess of the driver
4385428 
Add sub reaper to wait for stunnel processes
@leakingtapan
Copy link
Contributor Author

leakingtapan commented Dec 30, 2019 •
edited

@mogren addressed the comment :)

mogren
mogren approved these changes Dec 30, 2019
View reviewed changes
Copy link

@mogren mogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leakingtapan
Copy link
Contributor Author

/retest

@leakingtapan leakingtapan merged commit 019e989 into kubernetes-sigs:master Dec 30, 2019
@leakingtapan leakingtapan deleted the watch-dog branch December 30, 2019 18:23
@Cappuccinuo Cappuccinuo mentioned this pull request Jun 1, 2020
Closed
@wongma7 wongma7 mentioned this pull request Jul 13, 2021
Closed
@smrutiranjantripathy smrutiranjantripathy mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogren mogren mogren approved these changes

@d-nishi d-nishi Awaiting requested review from d-nishi

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start efs stunnel watch dog
3 participants
@leakingtapan @k8s-ci-robot @mogren