Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding amd64 as nodeSelector to avoid arm64 archtectures (#143) #144

Merged
merged 1 commit into from Apr 10, 2020
Merged

Adding amd64 as nodeSelector to avoid arm64 archtectures (#143) #144

merged 1 commit into from Apr 10, 2020

Conversation

hugoprudente
Copy link
Contributor

Is this a bug fix or adding new feature?
It's improvement

What is this PR about? / Why do we need it?
Adding a nodeSelector to for the aws-efs-csi-driver target only amd64 machines for multi cluster architectures.

Fixing Issue #143

What testing is done?
Yes, it's running on my multin-ode architecture

Nodes

± |affinity U:1 ✗| → k get nodes -o wide | grep amzn2
ip-10-0-29-162.eu-west-1.compute.internal   Ready    <none>   4d2h    v1.15.10-eks-bac369   10.0.29.162   <none>        Amazon Linux 2                   4.14.171-136.231.amzn2.x86_64    docker://18.9.9
ip-10-0-87-226.eu-west-1.compute.internal   Ready    <none>   2d5h    v1.15.10-eks-bac369   10.0.87.226   <none>        Amazon Linux 2                   4.14.171-136.231.amzn2.aarch64   docker://18.9.9
ip-10-0-93-165.eu-west-1.compute.internal   Ready    <none>   4d2h    v1.15.10-eks-bac369   10.0.93.165   <none>        Amazon Linux 2                   4.14.171-136.231.amzn2.x86_64    docker://18.9.9

Pods

kube-system         efs-csi-node-2rnfg                                         3/3     Running            0          14s
kube-system         efs-csi-node-4mhpm                                         3/3     Running            0          41s
kube-system         efs-csi-node-8rst2                                         3/3     Running            0          28s

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 23, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @hugoprudente!

It looks like this is your first PR to kubernetes-sigs/aws-efs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-efs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @hugoprudente. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2020
@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 24, 2020
@leakingtapan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020
@leakingtapan
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugoprudente, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0df5cfb into kubernetes-sigs:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants