WIP: DO NOT MERGE! Revert "Introduce Controller with Create and Delete Volume capability" #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f2fc7ce.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
we do like the dynamic provisioning functionality. Is the plan to add it back soon? |
|
/close |
|
@wongma7: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for testing a hypothetical 1.1 release that has bottlerocket (and other small) fixes but not dynamic provisioning.
I won't merge this into master. I plan to creatge a release-1.1 branch thta looks like this. I could also rebase and drop the controller commit but I think having an explicit revert is cleaner.
Ref, check commits since Jul 22:
https://github.com/kubernetes-sigs/aws-efs-csi-driver/commits/master/cmd
https://github.com/kubernetes-sigs/aws-efs-csi-driver/commits/master/pkg
This reverts commit f2fc7ce.
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
What testing is done?