Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ECR sidecars by default in helm and kustomize instead of gcr #371

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Mar 18, 2021

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?

helm

  • chart v1.2.1: default to getting driver from docker hub and sidecars from ecr public.ecr.aws/eks-distro/kubernetes-csi

kustomize

  • stable overlay: default to getting driver from docker hub and sidecars from ecr public.ecr.aws/eks-distro/kubernetes-csi
  • stable/ecr overlay: get driver from ecr 602401143452 and sidecars from ecr public.ecr.aws/eks-distro/kubernetes-csi

What testing is done?

helm

$ helm upgrade -i aws-efs-csi-driver ./charts/aws-efs-csi-driver
--namespace kube-system

NAME READY STATUS RESTARTS AGE
efs-csi-controller-67b5cd44b-5rlvs 3/3 Running 0 18m
efs-csi-controller-67b5cd44b-8rztb 3/3 Running 0 18m
efs-csi-node-68qfm 3/3 Running 0 17m
efs-csi-node-dmxg7 3/3 Running 0 16m
efs-csi-node-n8d8f 3/3 Running 0 16m
efs-csi-node-rkcps 3/3 Running 0 17m

$ helm del aws-efs-csi-driver -n kube-system

kustomize

$ k apply -k ./deploy/kubernetes/overlays/stable

efs-csi-controller-746bf5488d-kbnqm 3/3 Running 0 31s
efs-csi-controller-746bf5488d-sfxt7 3/3 Running 0 31s
efs-csi-node-9gmft 3/3 Running 0 31s
efs-csi-node-ghsb8 3/3 Running 0 31s
efs-csi-node-p5f9x 3/3 Running 0 31s
efs-csi-node-sp2z2 3/3 Running 0 31s

$ k apply -k ./deploy/kubernetes/overlays/stable/ecr
efs-csi-controller-67bbc46cd6-nr8sg 3/3 Running 0 34s
efs-csi-controller-67bbc46cd6-qhvvp 3/3 Running 0 40s
efs-csi-node-5qnrd 3/3 Running 0 32s
efs-csi-node-wrkhx 3/3 Running 0 18s
efs-csi-node-zn7qw 3/3 Running 0 7s
efs-csi-node-znsbh 3/3 Running 0 3s

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 18, 2021
@wongma7 wongma7 mentioned this pull request Mar 18, 2021
@jqmichael
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jqmichael, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9908f71 into kubernetes-sigs:release-1.2 Mar 18, 2021
@wongma7 wongma7 added this to the 1.2 milestone Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants