Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert efs-utils to 1.28.2 #385

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Mar 23, 2021

Is this a bug fix or adding new feature? /bug

What is this PR about? / Why do we need it? I am reasonably sure that this is contributing to the high failure rate https://testgrid.k8s.io/provider-aws-efs-csi-driver#e2e-test&width=20. Locally I ran the test and reproduced the write pod hanginga fter the driver pod restarts (it cannot read or write to the efs mount point). I then replaced the driver pod with a 1.1 version and the mount stopped hanging.

What testing is done?

@wongma7 wongma7 added this to the 1.2 milestone Mar 23, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 23, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 23, 2021
@nckturner
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wongma7
Copy link
Contributor Author

wongma7 commented Mar 23, 2021

If CI fares better then efs-utils is the culprit. I will make a bugfix release (1.2.1) and debug later.

If there is no improvement then efs-utils is not the culprit. I will debug.

@k8s-ci-robot k8s-ci-robot merged commit 5553490 into kubernetes-sigs:release-1.2 Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants