Add support for HDD Storage Type

[gkao123]

Is this a bug fix or adding new feature?
Adding support for HDD, a new FSx feature

https://aws.amazon.com/about-aws/whats-new/2020/08/amazon-fsx-lustre-announces-high-performance-hdd-based-shared-storage-compute-workloads/

What testing is done?
End to end testing

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @gkao123. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[leakingtapan]

/ok-to-test

[gkao123]

@leakingtapan Hi Cheng, the tests are failing due to the following error message:
failed to created filesystem There is already a disk with same ID and different size.

Could this be related to previous failed test runs?

[wongma7]

I think the bug has to do with how we resuse the same fsid forall tests to avoid hitting the 5 minute creation timeout, but we should not need to anymore ever since kubernetes/kubernetes#84140 merged

[wongma7]

Never mind, I am not sure the issue, because actually it is the pre-provisioned tests (these tests are SUPPOSED to resuse the same volume) that are failing. will keep digging.

[wongma7]

OK, I checked cloudtrail and the error there does not match what we got back?

    "errorCode": "IncompatibleParameterError",
    "errorMessage": "The cache type can not be specified for a lustre file system with DeploymentType=SCRATCH_1",

Never mind about the volume reuse stuff, since BOTH dynamic provisioning and pre-provisioned tests make a CreateVolume call, and the reuse issue was fixed a long time ago already, that can't be it even though the error message "
failed to created filesystem There is already a disk with same ID and different size " sounds a lot like it.

[wongma7]

per my latest comment including the cloudtrail message, also need to set deploymentType to PERSISTENT_1?

[gkao123]

I included this line of code due to a previous test failure. I realize now that the previous test failure was related to a bug in another code path, so I've gone ahead and removed this parameter in the latest revision.

[wongma7]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gkao123, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment