Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.5.3] The declared AWS dependency in go.mod and vendor/modules.txt differ #377

Closed
stig opened this issue Jun 9, 2021 · 0 comments · Fixed by #388
Closed

[0.5.3] The declared AWS dependency in go.mod and vendor/modules.txt differ #377

stig opened this issue Jun 9, 2021 · 0 comments · Fixed by #388

Comments

@stig
Copy link
Contributor

stig commented Jun 9, 2021

The AWS dependency in go.mod was updated between 0.5.2 and 0.5.3, but vendor/modules.txt was not. This is causing an inconsistency that currently is blocking (or at least making more difficult) bumping the aws-iam-authenticator version in nixpkgs, cf NixOS/nixpkgs#126335 (comment)

Could we have a fix to vendor/modules.txt and a new release please?
@stig stig mentioned this issue Jun 9, 2021
Closed
stig added a commit to stig/nixpkgs that referenced this issue Jun 9, 2021
@stig
aws-iam-authenticator: 0.5.2 -> 0.5.3
38e40a7 
I had to work around inconsistent vendoring; see
kubernetes-sigs/aws-iam-authenticator#377
stig added a commit to stig/nixpkgs that referenced this issue Jun 10, 2021
@stig
aws-iam-authenticator: 0.5.2 -> 0.5.3
313740d 
I had to work around inconsistent vendoring; see
kubernetes-sigs/aws-iam-authenticator#377

(cherry picked from commit 38e40a7)
@nckturner nckturner mentioned this issue Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run go mod vendor nckturner/aws-iam-authenticator
1 participant
@stig