Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deps #396

Merged
merged 2 commits into from Nov 23, 2021
Merged

Fix deps #396

merged 2 commits into from Nov 23, 2021

Conversation

frioux
Copy link
Contributor

@frioux frioux commented Sep 16, 2021

This program ends up depending on go.hein.dev/go-version, which depends on a really old version of cobra. I removed that package and reimplemented it's functionality to allow upgrading deps. At the same time I removed all the vendored stuff, but I'd be willing to not do that part, it was just the easiest way for me to get this to work.

As a side note: I also submitted a PR to go.hein.dev/go-version that would fix this once merged and this package updates to that version.

Fixes #383

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @frioux!

It looks like this is your first PR to kubernetes-sigs/aws-iam-authenticator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-iam-authenticator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 16, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2021
@frioux
Copy link
Contributor Author

frioux commented Oct 21, 2021

FYI I don't intend to rebase this again unless a human asks me to. Seems like it's just being ignored.

@nckturner
Copy link
Contributor

If you want to update this PR to not remove all the vendored deps, I am willing to merge it. Fewer dependencies is a good thing and I don't think we need a separate package for a version command.

@frioux
Copy link
Contributor Author

frioux commented Nov 19, 2021 via email

Remove the use of go.hein.dev/go-version since it causes some of the issues.
@frioux
Copy link
Contributor Author

frioux commented Nov 19, 2021

@nckturner done!

@nckturner
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frioux, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit d1861ea into kubernetes-sigs:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deps
3 participants