Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move inactives to emeritus_approvers and add active users #399

Merged
merged 1 commit into from Sep 28, 2021
Merged

Move inactives to emeritus_approvers and add active users #399

merged 1 commit into from Sep 28, 2021

Conversation

nckturner
Copy link
Contributor

@nckturner nckturner commented Sep 28, 2021 •
edited

  • Move inactives to emeritus
  • Add wongma7 to reviewers because he was only in approvers
  • Add Jay to approvers and reviewers

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Sep 28, 2021
@nckturner
Copy link
Contributor Author

/assign @wongma7
/cc @jaypipes

@k8s-ci-robot
Copy link
Contributor

@nckturner: GitHub didn't allow me to request PR reviews from the following users: jaypipes.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @wongma7
/cc @jaypipes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nckturner nckturner changed the title Move inactives to emeritus_approvers Move inactives to emeritus_approvers and add active users Sep 28, 2021
@nckturner
Copy link
Contributor Author

Let me remove Jay, and after he becomes a member we can add him.

@nckturner
Move inactives to emeritus_approvers
321f4c7 
- Add wongma7 to reviewers because he was only in approvers
- Add Jay to approvers and reviewers
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 28, 2021
@wongma7
Copy link
Contributor

wongma7 commented Sep 28, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 46df8d1 into kubernetes-sigs:master Sep 28, 2021
@jyotimahapatra jyotimahapatra mentioned this pull request Feb 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@micahhausler micahhausler Awaiting requested review from micahhausler

Assignees

@wongma7 wongma7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nckturner @k8s-ci-robot @wongma7