Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a counter for API server watch failures #400

Merged
merged 1 commit into from Oct 5, 2021

Conversation

nckturner
Copy link
Contributor

@nckturner nckturner commented Sep 30, 2021

  • New metrics package
  • Use new registry in test setup to avoid duplicate metric registration

Replaces: #387

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 30, 2021
@wongma7
Copy link
Contributor

wongma7 commented Sep 30, 2021

expose the metrics over http?

https://pkg.go.dev/github.com/prometheus/client_golang/prometheus/promauto

func main() {
go Random()
http.Handle("/metrics", promhttp.Handler())
http.ListenAndServe(":1971", nil)
}

@wongma7
Copy link
Contributor

wongma7 commented Sep 30, 2021

or i guess they are already exposed but show a curl example : D

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 4, 2021
- New metrics package
- Use new registry in test setup to avoid duplicate metric registration
- Use same package for authenticate endpoint latency histogram
@nckturner
Copy link
Contributor Author

With MountedFile:

$ curl -k https://localhost:21362/metrics | grep "configmap_watch_failures"
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                                                                                                            
                                 Dload  Upload   Total   Spent    Left  Speed                                                                                                                              
100  7915    0  7915    0     0   # HELP aws_iam_authenticator_configmap_watch_failures EKS Configmap watch failures                                                                                       
85# TYPE aws_iam_authenticator_configmap_watch_failures counter                                                                                                                                            
8aws_iam_authenticator_configmap_watch_failures 0                                                                                                                                                          
k      0 --:--:-- --:--:-- --:--:--  858k        

And with EKSConfigMap, but API server not running, after a few seconds:

$ curl -k https://localhost:21362/metrics |grep "configmap_watch_failures"                                                                            [22:53:08]
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                                                                                                            
                                 Dload  Upload   Total   Spent    Left  Speed                                                                                                                              
100  6416    0  6416# HELP aws_iam_authenticator_configmap_watch_failures EKS Configmap watch failures                                                                                                     
  # TYPE aws_iam_authenticator_configmap_watch_failures counter                                                                                                                                            
  aws_iam_authenticator_configmap_watch_failures 2                                                                                                                                                         

@wongma7
Copy link
Contributor

wongma7 commented Oct 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit a90afa1 into kubernetes-sigs:master Oct 5, 2021
Copy link
Contributor

@jyotimahapatra jyotimahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants