chore: Update app K8s dependencies #687

bryantbiggs · 2024-01-04T12:32:33Z

What this PR does / why we need it:

Updates application's K8s dependencies
Closes Update go.mods to use latest version of k8s.io/client-go #627
Resolves CVE: PRISMA-2022-0227 in emicklei/go-restful/v3 #635
Relates [Feature request]: Run and publish a security scanning bulletin #611

This is part of splitting out changes from #684 in smaller increments. make test passes successfully locally on this change set

...
--- PASS: TestGetIdentityFromSTSResponse (0.00s)
    --- PASS: TestGetIdentityFromSTSResponse/Root_User (0.00s)
    --- PASS: TestGetIdentityFromSTSResponse/User (0.00s)
    --- PASS: TestGetIdentityFromSTSResponse/Role (0.00s)
    --- PASS: TestGetIdentityFromSTSResponse/Federated_User (0.00s)
PASS
coverage: 75.7% of statements
ok  	sigs.k8s.io/aws-iam-authenticator/pkg/token	1.442s	coverage: 75.7% of statements
go tool cover -html=coverage.out -o coverage.html

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

k8s-ci-robot · 2024-01-04T12:32:43Z

Hi @bryantbiggs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jyotimahapatra · 2024-01-04T17:38:17Z

/ok-to-test

jyotimahapatra · 2024-01-04T17:39:09Z

/lgtm

…text handling

bryantbiggs · 2024-01-04T19:06:34Z

/retest

bryantbiggs · 2024-01-04T23:04:40Z

/retest

…gh WithDisruptive instead

bryantbiggs · 2024-01-08T01:05:06Z

struggling to figure out this ginkgo error:

 Unknown Decorator
var _ = Describe("[apiserver] the apiserver", framework.WithDisruptive(), func() {
/home/prow/go/src/github.com/kubernetes-sigs/aws-iam-authenticator/tests/e2e/apiserver_test.go:44
  [Container] node was passed an unknown decorator:
  'framework.label{parts:[]string{"Disruptive"}, extra:""}'
  Learn more at: http://onsi.github.io/ginkgo/#node-decorators-overview

Which was previously:

ERROR: E2E suite initialization was faulty, these errors must be fixed:
ERROR: apiserver_test.go:44: [Disruptive] in plain text is deprecated and must be added through WithDisruptive instead

bryantbiggs · 2024-01-12T21:58:44Z

cc @jyotimahapatra if you get a moment to re-review, thank you!

jyotimahapatra · 2024-01-16T17:04:31Z

tests/e2e/apiserver_test.go


 	When("the manifest changes", func() {
 		BeforeEach(func() {
-			cfg, _ = clientcmd.BuildConfigFromFlags("", framework.TestContext.KubeConfig)


for familiarity: is this not needed because f := framework.NewDefaultFramework("apiserver") is added above?

yes! I'm not well versed in the testing framework but upstream has made several ergonomic improvements so now the config and client set can be extracted from the framework itself

jyotimahapatra · 2024-01-16T17:05:54Z

.gitignore

@@ -69,3 +69,6 @@ cscope.*
 # coverage.out file
 coverage.out
 coverage.html
+
+# multi-module workspaces
+go.work*


curious: did we multi module workspace for a needed functionality?

to be honest, I don't know the full implications of adding this to the project. but my IDE was failing to resolve paths without the multi-module workspace setup so I added it to work locally but that creates a go.work (that looks like below) and a go.work.sum. I'm happy to go any way with this - revert the change to the gitignore, keep it, add the go.work* files, etc.

// go.work go 1.21 use ( ./tests/e2e ./tests/integration )

based on kubernetes/enhancements#4402 - perhaps we do not want to ignore the go workspaces and instead start utilizing them?

bryantbiggs · 2024-01-19T13:51:49Z

@jyotimahapatra / @nnmin-aws let me know if there are any other comments or feedback that I can help address, thank you!

nnmin-aws · 2024-01-22T17:27:51Z

/lgtm

nnmin-aws · 2024-02-29T17:31:38Z

/lgtm

… into chore/update-app-k8s-dependencies

nnmin-aws · 2024-04-22T03:40:07Z

/lgtm

wongma7 · 2024-04-22T17:25:23Z

/approve

k8s-ci-robot · 2024-04-22T17:25:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryantbiggs, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [wongma7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…app-k8s-dependencies chore: Update app K8s dependencies

chore: Update app K8s dependencies

b9a669a

k8s-ci-robot requested review from justinsb and jyotimahapatra January 4, 2024 12:32

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2024

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 4, 2024

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2024

k8s-ci-robot assigned jyotimahapatra Jan 4, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2024

fix: Downgrade k8s.io/sample-controller which requires updating con…

0b8771f

…text handling

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2024

fix: Integration test dependencies run go mod tidy

ec140f7

fix: Fix codegen and update replace test integration dependencies

a66aaea

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 4, 2024

bryantbiggs added 3 commits January 4, 2024 19:16

fix: Align integration test replace versions in go.mod

bac75be

fix: Add context to StartTestServer

5c3b5a5

chore: Update dependencies for e2e tests

2464b9d

bryantbiggs force-pushed the chore/update-app-k8s-dependencies branch from 993becf to 2464b9d Compare January 5, 2024 01:32

fix: [Disruptive] in plain text is deprecated and must be added throu…

acbfad3

…gh WithDisruptive instead

This was referenced Jan 6, 2024

chore: Update test dependencies and run make format #686

Closed

chore: Update k8s.io libraries #684

Closed

fix: Use framework.WithDisruptive()

6c94ad6

jyotimahapatra reviewed Jan 16, 2024

View reviewed changes

feat: Re-update K8s packages to latest release

d872c1f

k8s-ci-robot assigned nnmin-aws Jan 22, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2024

chore: Re-update and align

3fa67f1

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2024

chore: Re-update to latest patch version of K8s packages

309922a

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024

bryantbiggs mentioned this pull request Mar 6, 2024

update kubernetes client version #697

Closed

bryantbiggs mentioned this pull request Mar 15, 2024

Bump github.com/golang/protobuf v1.5.4, google.golang.org/protobuf v1.33.0 #698

Merged

Merge branch 'master' of github.com:bryantbiggs/aws-iam-authenticator…

4ac7942

… into chore/update-app-k8s-dependencies

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024

bryantbiggs mentioned this pull request Apr 19, 2024

updating k8s client libraries and go version #706

Closed

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024

k8s-ci-robot merged commit 7007017 into kubernetes-sigs:master Apr 22, 2024
6 checks passed

bryantbiggs deleted the chore/update-app-k8s-dependencies branch April 22, 2024 17:59

This was referenced Apr 22, 2024

chore: Update CLI dependencies cobra and viper #689

Merged

Remove misc files that are no longer used #680

Merged

bryantbiggs mentioned this pull request Apr 25, 2024

Release 0.6 #712

Closed

jaidevmane pushed a commit to jaidevmane/aws-iam-authenticator that referenced this pull request Apr 25, 2024

Merge pull request kubernetes-sigs#687 from bryantbiggs/chore/update-…

27919d5

…app-k8s-dependencies chore: Update app K8s dependencies

jaidevmane pushed a commit to jaidevmane/aws-iam-authenticator that referenced this pull request Apr 25, 2024

Merge pull request kubernetes-sigs#687 from bryantbiggs/chore/update-…

f925394

…app-k8s-dependencies chore: Update app K8s dependencies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update app K8s dependencies #687

chore: Update app K8s dependencies #687

bryantbiggs commented Jan 4, 2024 •

edited

k8s-ci-robot commented Jan 4, 2024

jyotimahapatra commented Jan 4, 2024

jyotimahapatra commented Jan 4, 2024

bryantbiggs commented Jan 4, 2024

bryantbiggs commented Jan 4, 2024

bryantbiggs commented Jan 8, 2024 •

edited

bryantbiggs commented Jan 12, 2024

jyotimahapatra Jan 16, 2024

bryantbiggs Jan 16, 2024

jyotimahapatra Jan 16, 2024

bryantbiggs Jan 16, 2024

bryantbiggs Feb 29, 2024

bryantbiggs commented Jan 19, 2024 •

edited

nnmin-aws commented Jan 22, 2024

nnmin-aws commented Feb 29, 2024

nnmin-aws commented Apr 22, 2024

wongma7 commented Apr 22, 2024

k8s-ci-robot commented Apr 22, 2024

chore: Update app K8s dependencies #687

chore: Update app K8s dependencies #687

Conversation

bryantbiggs commented Jan 4, 2024 • edited

k8s-ci-robot commented Jan 4, 2024

jyotimahapatra commented Jan 4, 2024

jyotimahapatra commented Jan 4, 2024

bryantbiggs commented Jan 4, 2024

bryantbiggs commented Jan 4, 2024

bryantbiggs commented Jan 8, 2024 • edited

bryantbiggs commented Jan 12, 2024

jyotimahapatra Jan 16, 2024

Choose a reason for hiding this comment

bryantbiggs Jan 16, 2024

Choose a reason for hiding this comment

jyotimahapatra Jan 16, 2024

Choose a reason for hiding this comment

bryantbiggs Jan 16, 2024

Choose a reason for hiding this comment

bryantbiggs Feb 29, 2024

Choose a reason for hiding this comment

bryantbiggs commented Jan 19, 2024 • edited

nnmin-aws commented Jan 22, 2024

nnmin-aws commented Feb 29, 2024

nnmin-aws commented Apr 22, 2024

wongma7 commented Apr 22, 2024

k8s-ci-robot commented Apr 22, 2024

bryantbiggs commented Jan 4, 2024 •

edited

bryantbiggs commented Jan 8, 2024 •

edited

bryantbiggs commented Jan 19, 2024 •

edited