-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature gates for ALB addons #1479
Conversation
add aws-max-retries cmdline flag add controller config options add feature gates for waf, wafv2 and shield
Hi @kishorj. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kishorj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.let’s have a package like pkg/config/controller_config.go
pkg/config/ingress_config.go
pkg/config/addons_config.go
, the controllers
/webhooks
outside of /pkg shouldn’t be imported by others
2. seems we don’t need this FeatureGate interface anymore..a simple AddonsConfig structure should do the job and more extensible(e.g. add addon settings) (edited)
10:17
3. the scheme and setupLog and +kubebuilder:scaffold:scheme i feel better to remain at go. so maybe just have a pure data structure of these configs in pkg/config/controller_config.go instead of /pkg/runtime/config.go (avoid the interface). we can have functions defined in either /pkg/config/controller_config.go or directly in main.go to calculate rest config and ctrl.options from the controller config
add support for log-level flag hoonor the ingress-class flag configuration use AddonsConfig instead of FeatureGates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
New changes are detected. LGTM label has been removed. |
* add feature gates and refactor command line flags add aws-max-retries cmdline flag add controller config options add feature gates for waf, wafv2 and shield * add sync-period flag * specify config as pure data add support for log-level flag hoonor the ingress-class flag configuration use AddonsConfig instead of FeatureGates * refactor, get rid of inClusterConfig warning * add webhook-bind-port and metrics-bind-addr flags * cleanup unused imports
add feature gates for waf, wafv2 and shield addons
add aws-max-retries cmdline flag
add controller config options
Fixes: #1482
Tests run
Disabled the ALB addons via the feature gate, and added following annotations to the ingress object
Verified that the ingress got reconciled successfully.
NLB IP service and Ingress were reconciled as expected.