Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gates for ALB addons #1479

Merged
merged 6 commits into from
Oct 10, 2020
Merged

Add feature gates for ALB addons #1479

merged 6 commits into from
Oct 10, 2020

Conversation

kishorj
Copy link
Collaborator

@kishorj kishorj commented Oct 9, 2020

add feature gates for waf, wafv2 and shield addons
add aws-max-retries cmdline flag
add controller config options

Fixes: #1482

Tests run
Disabled the ALB addons via the feature gate, and added following annotations to the ingress object

alb.ingress.kubernetes.io/waf-acl-id: invalid-waf-acl
alb.ingress.kubernetes.io/wafv2-acl-arn: invalid-wafv2-acl
alb.ingress.kubernetes.io/shield-advanced-protection: 'true'

Verified that the ingress got reconciled successfully.

NLB IP service and Ingress were reconciled as expected.

add aws-max-retries cmdline flag
add controller config options
add feature gates for waf, wafv2 and shield
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @kishorj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kishorj
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2020
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.let’s have a package like pkg/config/controller_config.go pkg/config/ingress_config.go pkg/config/addons_config.go, the controllers/webhooks outside of /pkg shouldn’t be imported by others
2. seems we don’t need this FeatureGate interface anymore..a simple AddonsConfig structure should do the job and more extensible(e.g. add addon settings) (edited)
10:17
3. the scheme and setupLog and +kubebuilder:scaffold:scheme i feel better to remain at go. so maybe just have a pure data structure of these configs in pkg/config/controller_config.go instead of /pkg/runtime/config.go (avoid the interface). we can have functions defined in either /pkg/config/controller_config.go or directly in main.go to calculate rest config and ctrl.options from the controller config

add support for log-level flag
hoonor the ingress-class flag configuration
use AddonsConfig instead of FeatureGates
controllers/ingress/group_controller.go Outdated Show resolved Hide resolved
pkg/config/runtime_config.go Show resolved Hide resolved
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2020
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@M00nF1sh M00nF1sh merged commit 28ffaf3 into kubernetes-sigs:v2_ga Oct 10, 2020
@kishorj kishorj deleted the v2_ga_feature_gate branch October 27, 2020 04:11
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
* add feature gates and refactor command line flags

add aws-max-retries cmdline flag
add controller config options
add feature gates for waf, wafv2 and shield

* add sync-period flag

* specify config as pure data

add support for log-level flag
hoonor the ingress-class flag configuration
use AddonsConfig instead of FeatureGates

* refactor, get rid of inClusterConfig warning

* add webhook-bind-port and metrics-bind-addr flags

* cleanup unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants