Add e2e tests for NLB IP mode #1500
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @kishorj. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kishorj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XL
- Add support for e2e testing of AWS NLB in IP mode - Verify target group health check config - Test NLB access-log annotations - Test TLS annotations - Traffic tests
| @@ -14,5 +14,5 @@ func RandomDNS1123Label(length int) string { | |||
|
|
|||
| labelBuf := make([]byte, seedLen*2) | |||
| hex.Encode(labelBuf, seedBuf) | |||
| return string(labelBuf[:length]) | |||
There was a problem hiding this comment.
why do we change this RandomDNS1123Label? if we want a a prefix, we should use fmt.Sprintf("a%v, RandomDNS1123Label(length-1))
There was a problem hiding this comment.
RFC 1123 compliant labels cannot begin with a numeric character. Prepended "a" to force compliance.
* e2e tests for k8s service - Add support for e2e testing of AWS NLB in IP mode - Verify target group health check config - Test NLB access-log annotations - Test TLS annotations - Traffic tests * separate e2e tests from Makefile target
Run e2e tests with the following arguments
--kubeconfig=<kubeconfig_path> --cluster-name= --aws-region= --aws-vpc-id=